[jira] [Commented] (BEAM-6031) Add retry logic to S3FileSystem

["Ismaël Mejía (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688160#comment-16688160 ] 

Ismaël Mejía commented on BEAM-6031:
------------------------------------

[~pawelbartoszek] do you plan to work on this one? We have to be cautious that this retry logic does not break the consistency of retries on the Beam model. I mean failing quickly is better than inconsistency.

> Add retry logic to S3FileSystem 
> --------------------------------
>
>                 Key: BEAM-6031
>                 URL: https://issues.apache.org/jira/browse/BEAM-6031
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-aws
>    Affects Versions: 2.7.0, 2.8.0
>            Reporter: Pawel Bartoszek
>            Priority: Major
>
> S3FileSystem should have some retry behaviour if ObjectsDelete fails. I have seen such example in our job where 1 item from the delete batch cannot be deleted due to S3 InternalError causing the whole job to restart. The source code I am referring to:  
> [https://github.com/apache/beam/blob/8a88e72f293ef7f9be6c872aa0dda681458c7ca5/sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/S3FileSystem.java#L633]
>  
> The retry logic might be added to other S3 calls in S3FileSystem as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)