You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/08 16:29:00 UTC
[jira] [Commented] (DISPATCH-1771) misc test improvements
[ https://issues.apache.org/jira/browse/DISPATCH-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192303#comment-17192303 ]
ASF GitHub Bot commented on DISPATCH-1771:
------------------------------------------
gemmellr opened a new pull request #845:
URL: https://github.com/apache/qpid-dispatch/pull/845
PR for review of changes for DISPATCH-1771. Note I've marked it as a draft, this is just as the changes are kept deliberately seperate for ease of review, in specific commits not referencing the JIRA. I'll squash and add the JIRA key before pushing.
Misc test improvements to address the following:
- Various tests configure verifyHostname no/false needlessly. Most dont even use TLS and so obviously shouldn't configure this.
- Others aren't testing hostname verification, but disable it just due to having mismatching connector host detail.
- The verifyHostname tests have comments containing incorrect detail
- Various tests using TLS have extraneous cert config that isnt under test and will never be used due to what is being tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> misc test improvements
> ----------------------
>
> Key: DISPATCH-1771
> URL: https://issues.apache.org/jira/browse/DISPATCH-1771
> Project: Qpid Dispatch
> Issue Type: Test
> Reporter: Robbie Gemmell
> Priority: Minor
> Fix For: 1.14.0
>
>
> Misc test improvements to address the following:
> * Various tests configure verifyHostname no/false needlessly. Most dont even use TLS and so obviously shouldn't configure this.
> * Others aren't testing hostname verification, but disable it just due to having mismatching connector host detail.
> * The verifyHostname tests have comments containing incorrect detail
> * Various tests using TLS have extraneous cert config that isnt under test and will never be used due to what is being tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org