You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/19 09:53:59 UTC
[GitHub] [doris] starocean999 opened a new pull request, #11933: [fix](union)the result exprs of union node should substitute by child node's smap
starocean999 opened a new pull request, #11933:
URL: https://github.com/apache/doris/pull/11933
# Proposed changes
Issue Number: close #xxx
## Problem summary
union node's result exprs should be substitued by child node's smap first, then the following "computePassthrough" method would have correct information to do its job.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #11933: [fix](union)the result exprs of union node should substitute by child node's smap
Posted by GitBox <gi...@apache.org>.
starocean999 commented on code in PR #11933:
URL: https://github.com/apache/doris/pull/11933#discussion_r953445341
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -144,6 +144,13 @@ public List<List<Expr>> getMaterializedConstExprLists() {
@Override
public void finalize(Analyzer analyzer) throws UserException {
super.finalize(analyzer);
+ // the resultExprLists should be substituted by child's output smap
Review Comment:
modified, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11933: [fix](union)the result exprs of union node should substitute by child node's smap
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11933:
URL: https://github.com/apache/doris/pull/11933#discussion_r953313356
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -144,6 +144,13 @@ public List<List<Expr>> getMaterializedConstExprLists() {
@Override
public void finalize(Analyzer analyzer) throws UserException {
super.finalize(analyzer);
+ // the resultExprLists should be substituted by child's output smap
Review Comment:
if we has substitute `resultExprLists`, should we still need substitute when we generate `materializedResultExprLists` in next code block in finalize?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11933: [fix](union)the result exprs of union node should substitute by child node's smap
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11933:
URL: https://github.com/apache/doris/pull/11933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org