You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Mate Czagany (Jira)" <ji...@apache.org> on 2024/10/10 11:23:00 UTC

[jira] [Commented] (FLINK-36467) Bump google-java-format and spotless

    [ https://issues.apache.org/jira/browse/FLINK-36467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888242#comment-17888242 ] 

Mate Czagany commented on FLINK-36467:
--------------------------------------

We can follow the same practices as in FLINK-20651:
 * git author should be "Rufus Refactor <de...@flink.apache.org>"
 * add commit hash to .git-blame-ignore-revs file
 * ensure that the .editorconfig file is up-to-date

> Bump google-java-format and spotless
> ------------------------------------
>
>                 Key: FLINK-36467
>                 URL: https://issues.apache.org/jira/browse/FLINK-36467
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Mate Czagany
>            Priority: Major
>
> Currently 1.7 google-java-format is used to format the code because this is the last release that supports JDK 8. Since this version does not support JDK 21, the spotless plugin is disabled when using that JDK.
> This ticket is to bump the version of google-java-format to 1.24.0 which is probably the latest version that will support JDK 11. With this we should also bump spotless version to the latest, 2.43.0.
> This would also include many changes to the existing code due to formatting changes introduced in newer google-java-format releases. 
> I have a commit with the formatting changes from 1.7 -> 1.24.0 here: [https://github.com/mateczagany/flink/commit/6b92710e25df7486bb230bfe16b17f8bc1f22578#diff-8ade883f48062678bf5ca9394ece19699e1984ffbc108f2b51812c2f516a55da]
>  
> Google Java Format releases: [https://github.com/google/google-java-format/releases]
> Commits between 1.7 and 1.24.0: [https://github.com/google/google-java-format/compare/google-java-format-1.7...v1.24.0]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)