You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/11 00:11:00 UTC

[jira] [Commented] (AIRFLOW-5636) Allow adding or overriding existing Extra Operator Links for existing Operators

    [ https://issues.apache.org/jira/browse/AIRFLOW-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949014#comment-16949014 ] 

ASF GitHub Bot commented on AIRFLOW-5636:
-----------------------------------------

kaxil commented on pull request #6302: [AIRFLOW-5636] Allow adding or overriding existing Operator Links for…
URL: https://github.com/apache/airflow/pull/6302
 
 
   … an Operator
   
   This will be done via Airflow Plugins
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5636
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Currently, we can add Operator link globally for all tasks or add operator links in existing tasks.
   
   We should be able to add Operator links on a Single Operator or override existing Operator link on an operator. 
   
   This PR adds this functionality. This would also help in adding Operator links once we enable Serialized DAGs #5743  
   
   In the future, this will become a **de facto** way of adding OperatorLinks.
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow adding or overriding existing Extra Operator Links for existing Operators
> -------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5636
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5636
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core, plugins, ui
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>             Fix For: 2.0.0, 1.10.6
>
>
> Currently, we can add Operator link globally for all tasks or add operator links in existing tasks.
> We should be able to add Operator links on a Single Operator or override existing Operator link on an operator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)