Re: [PR] Do not import the stored path when rebuilding a Callback from serialized data [airflow]

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #70704:
URL: https://github.com/apache/airflow/pull/70704#discussion_r3701658145


##########
task-sdk/src/airflow/sdk/definitions/callback.py:
##########
@@ -66,6 +80,14 @@ def get_callback_path(cls, _callback: str | Callable) -> str:
 
         stripped_callback = _callback.strip()
 
+        if isinstance(_callback, _SerializedCallbackPath):
+            # This path was already checked when the Callback it belongs to was created, so
+            # rebuilding that Callback keeps it as it is. Reconstruction happens in components
+            # which never call the callback themselves, and resolving the path there is neither
+            # needed nor wanted: the module it names is not necessarily importable in that
+            # process, and importing it has no bearing on the path we return either way.
+            return stripped_callback

Review Comment:
   Both the docstring and usage almost narrate the same thing, suggest removing in one of them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org