[GitHub] [james-project] Arsnael commented on a change in pull request #504: JAMES-3516 Add threadId column to cassandra tables

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r656093590



##########
File path: mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/table/MessageIdToImapUid.java
##########
@@ -29,6 +29,8 @@
 
     String MOD_SEQ = "modSeq";
 
-    String[] FIELDS = { MESSAGE_ID, MAILBOX_ID, IMAP_UID, MOD_SEQ,
+    String THREAD_ID = "threadId";

Review comment:
       Maybe I would have added that constant in `CassandraMessageIds` and then import it here and in CassandraMessageIdTable instead

##########
File path: src/site/xdoc/server/config-cassandra.xml
##########
@@ -319,6 +319,12 @@
 
     </subsection>
 
+    <subsection name="From V10 to V11">
+
+      <p>Add threadId column to messageIdTable and imapUidTable in order to get a message's threadId.</p>

Review comment:
       We should give the commands on Cassandra to perform for that I believe. But I consider that you probably don't know them.
   
   I will try to support you on this part when I have a bit of time.
   
   I think we need to modify the proper section in the new doc with Antora too :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org