You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Norberto Meijome (JIRA)" <ji...@apache.org> on 2008/07/15 02:45:33 UTC
[jira] Created: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Upgrade bundled Jetty with latest from vendor
---------------------------------------------
Key: SOLR-632
URL: https://issues.apache.org/jira/browse/SOLR-632
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Norberto Meijome
Priority: Minor
Fix For: 1.3
The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
We should upgrade Jetty to the latest, 6.1.11.
I am not sure how to attach a patch to remove files, so these are the steps :
Using as base the root of 'apache-solr-nightly':
DELETE:
example/lib/jetty-6.1.3.jar
example/lib/jetty-util-6.1.3.jar
example/lib/servlet-api-2.5-6.1.3.jar
ADD
example/lib/jetty-6.1.11.jar
example/lib/jetty-util-6.1.11.jar
example/lib/servlet-api-2.5-6.1.11.jar
---
The files to be added can be found in Jetty's binary distribution file :
http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-632.
-------------------------------
Resolution: Fixed
Norberto - thanks for testing this out. I've upgraded and tested things out and the basics seem fine. Committed.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614649#action_12614649 ]
Lars Kotthoff commented on SOLR-632:
------------------------------------
Jetty explicitely removes all headers related to caching (except pragma) when calling sendError() from SVN version 1917. I think that removing the headers is a sensible thing to do, as they could instruct a cache to store the error message.
I've filed a Jetty issue to set the Cache-Control header to explicitely prohibit caching (https://jira.codehaus.org/browse/JETTY-646). If we want to get the new Jetty version in with the 1.3 release then it's probably best to change the failing unit test to verify that at least no header instructing any caches to store the reply is set. OTOH, having Jetty change the headers on its own is probably going to require some changes to the HTTP caching code.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848332#action_12848332 ]
Mark Miller commented on SOLR-632:
----------------------------------
I'm trying out this upgrade (to 6.1.22) on newtrunk - seems like a nice time to get this done
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Norberto Meijome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614233#action_12614233 ]
Norberto Meijome commented on SOLR-632:
---------------------------------------
On Wed, 16 Jul 2008 16:07:31 -0700 (PDT)
:) my pleasure to be of some small help :)
_________________________
{Beto|Norberto|Numard} Meijome
Windows caters to everyone as though they are idiots. UNIX makes no such assumption. It assumes you know what you are doing, and presents the challenge of figuring it out for yourself if you don't.
I speak for myself, not my employer. Contents may be hot. Slippery when wet. Reading disclaimers makes you go blind. Writing them is worse. You have been Warned.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614657#action_12614657 ]
Lars Kotthoff commented on SOLR-632:
------------------------------------
bq. Is cache-control compulsory?
No.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616358#action_12616358 ]
Lars Kotthoff commented on SOLR-632:
------------------------------------
The Jetty issue has been resolved; the changes will be in version 6.1.12.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher reopened SOLR-632:
-------------------------------
weird - looking into it now.
i coulda swore i ran "ant clean test" last night successfully before committing. though i now too see the failure locally. sorry... more soon.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618257#action_12618257 ]
Shalin Shekhar Mangar commented on SOLR-632:
--------------------------------------------
Are we still targeting this to be in Solr 1.3 ? Is there an easy workaround for the test?
Seems like 6.1.12 will take time (the RC1 was released today)
http://www.nabble.com/Jetty-6.1.12-rc1-Available!-ts18721171.html
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618260#action_12618260 ]
Lars Kotthoff commented on SOLR-632:
------------------------------------
The only workaround is to disable the test :)
Switching to 6.1.11 means that for anybody using Solr with something that does HTTP caching error messages might be cached. In practice it's probably not a big deal, as most caching configurations don't cache non-200 responses anyway.
This could have a negative impact if the cache is instructed to store everything that doesn't explicitely allow caching and the time content is cached is very long or an error occurs only for a short time and more or less fixes itself.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614482#action_12614482 ]
Hoss Man commented on SOLR-632:
-------------------------------
Note: upgrading jetty seems to have broken a cache header related test...
http://hudson.zones.apache.org/hudson/job/Solr-trunk/501/
anybody have any idea why this would happen?
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Norberto Meijome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613501#action_12613501 ]
Norberto Meijome commented on SOLR-632:
---------------------------------------
i think is best if someone with write access to svn simply gets the files from mortbay.org and checks it in... i can always attach the files to the issue, but then you'd still want to verify its checksum....
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-632:
------------------------------
Fix Version/s: (was: 1.3)
This won't be tackled for 1.3.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher reassigned SOLR-632:
---------------------------------
Assignee: Erik Hatcher
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Norberto Meijome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618674#action_12618674 ]
Norberto Meijome commented on SOLR-632:
---------------------------------------
If Jetty 6.1.11 may cause more problems than 6.1.3, then let's leave 6.1.3 in the default distribution - we can always add a quick wiki page on what to change to upgrade the bundled jetty , with the caveats of the issues discovered in this bug.
-1 to 6.1.11 then :)
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Norberto Meijome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614656#action_12614656 ]
Norberto Meijome commented on SOLR-632:
---------------------------------------
LK>Jetty explicitely removes all headers related to caching (except pragma) when calling sendError() from SVN version 1917. I think that
LK> removing the headers is a sensible thing to do, as they could instruct a cache to store the error message.
+1
LK> I've filed a Jetty issue to set the Cache-Control header to explicitely prohibit caching (https://jira.codehaus.org/browse/JETTY-646). If we want
LK> to get the new Jetty version in with the 1.3 release then it's probably best to change the failing unit test to verify that at least no header
LK> instructing any caches to store the reply is set.
makes sense to me.
LK> OTOH, having Jetty change the headers on its own is probably going to require some
LK> changes to the HTTP caching code.
Is cache-control compulsory? if not, Jetty isnt' really breaking anything by not including it, and not really that high priority for Jetty - although having cache-control prohibiting cache would be a more proper approach.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-632:
------------------------------
Comment: was deleted
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614523#action_12614523 ]
Erik Hatcher commented on SOLR-632:
-----------------------------------
In debugging this, I clearly saw the Cache-Control header being set in HttpCacheHeaderUtil#checkHttpCachingVeto, but it totally disappears by the time it gets to CacheHeaderTest#checkVetoHeaders. The Pragma and ETag come out as expected, but not so with Cache-Control.
A bug in Jetty? *shrugs* Sure seems like it. Would love for someone with time on their hands to track this down and possibly report to the Jetty community.
I'm punting for now and reverting back to 6.1.3.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618793#action_12618793 ]
Erik Hatcher commented on SOLR-632:
-----------------------------------
Yeah, we'll just sit on this issue until the new Jetty comes out in final form. No big deal.... things work as-is and most importantly the Jetty container is "just an example" anyway. If users want to deploy in another container, that's perfectly acceptable.
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-632) Upgrade bundled Jetty with latest from
vendor
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614509#action_12614509 ]
Erik Hatcher commented on SOLR-632:
-----------------------------------
This looks like a possible culprit from Jetty's changelog http://svn.codehaus.org/jetty/jetty/branches/jetty-6.1/VERSION.txt :
jetty-6.1.2rc3 - 16 April 2007
+ Improvements to allow simple setting of Cache-Control headers
> Upgrade bundled Jetty with latest from vendor
> ---------------------------------------------
>
> Key: SOLR-632
> URL: https://issues.apache.org/jira/browse/SOLR-632
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Norberto Meijome
> Assignee: Erik Hatcher
> Priority: Minor
> Fix For: 1.3
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The Jetty that is bundled for the example application is version 6.1.3, which is over a year old.
> We should upgrade Jetty to the latest, 6.1.11.
> I am not sure how to attach a patch to remove files, so these are the steps :
> Using as base the root of 'apache-solr-nightly':
> DELETE:
> example/lib/jetty-6.1.3.jar
> example/lib/jetty-util-6.1.3.jar
> example/lib/servlet-api-2.5-6.1.3.jar
> ADD
> example/lib/jetty-6.1.11.jar
> example/lib/jetty-util-6.1.11.jar
> example/lib/servlet-api-2.5-6.1.11.jar
> ---
> The files to be added can be found in Jetty's binary distribution file :
> http://dist.codehaus.org/jetty/jetty-6.1.11/jetty-6.1.11.zip
> I couldn't find any noticeable changes in jetty.xml that should be carried over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.