You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2024/05/08 06:58:07 UTC

[kudu-CR] Leader rebalance ignores soft deleted tables

Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21411


Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is no needs too leader rebalance soft deleted
tables, which maybe cost a lot of time.
This path provide a configure
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
2 files changed, 96 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2024 11:48:56 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/154/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2024 10:57:30 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Chovan, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21411

to look at the new patch set (#6).

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which may take a long time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 122 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/6
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/156/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 May 2024 08:41:01 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/154/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2024 03:23:46 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21411/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21411/3//COMMIT_MSG@11
PS3, Line 11: may take a long time.
> may take a long time
Done


http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc@586
PS3, Line 586: rebalance
> nit: rebalanced
Done


http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc@592
PS3, Line 592: rebalance
> nit:rebalanced
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 May 2024 07:35:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/140/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2024 11:01:14 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@10
PS1, Line 10: no needs too leader rebalance
nit: not needed to do leader rebalance for


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12: provide
provides


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12: path
patch


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12: configure
configuration


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@90
PS1, Line 90: leader_rebalancing_filter_soft_deleted_tables
How about 'leader_rebalancing_ignore_soft_deleted_tables' to clarify?


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@435
PS1, Line 435:     catalog_manager_->GetAllTables(&table_infos);
GetAllTables returns a vector related to 'table_ids_map_', when 'normal' tables are needed, how about returning a vector related to 'normalized_table_names_map_' which only contians non-soft-deleted tables. You can add a function for the purpose.


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@437
PS1, Line 437: for (auto iter = table_infos.begin(); iter != table_infos.end(); iter++) {
nit: for (auto table_info : table_infos) { ?



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 11 May 2024 04:21:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3: Verified+1

Unrelated test failures:
asan: alter_table_test.0
tsan: org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2024 11:59:17 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc@592
PS4, Line 592:   GetLeaderDistribution(&leader_map, soft_deleted_table);
> nit: Move this line under 'if (FLAGS_leader_rebalancing_ignore_soft_deleted
Done


http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc@91
PS4, Line 91: Whether to ignore re
> Miss "ignore"?
Done


http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h@881
PS4, Line 881: GetNormalizedTa
> How about naming as 'GetNormalizedTables()'? Now 'normalized' and 'soft_del
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 02:36:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Chovan, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21411

to look at the new patch set (#5).

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which may take a long time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 121 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/5
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/140/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2024 10:07:19 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 09:48:26 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc@592
PS4, Line 592:   // The soft deleted table is not leader rebalanced.
nit: Move this line under 'if (FLAGS_leader_rebalancing_ignore_soft_deleted_tables)' clause.


http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc@91
PS4, Line 91: Whether to rebalance
Miss "ignore"?


http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h@881
PS4, Line 881: GetActiveTables
How about naming as 'GetNormalizedTables()'? Now 'normalized' and 'soft_deleted' are used to distinguish the tables, it would be better to unify the names.



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 02:27:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/157/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 02:35:56 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Chovan, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21411

to look at the new patch set (#4).

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which may take a long time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 121 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21411

to look at the new patch set (#2).

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which maybe cost a lot of time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 102 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 5:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/157/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 02:38:00 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21411

to look at the new patch set (#3).

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which maybe cost a lot of time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 121 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/21411/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/156/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 May 2024 07:33:52 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2024 12:00:07 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/119/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 May 2024 08:08:07 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/119/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 May 2024 06:58:15 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc@535
PS2, Line 535: class FilterSoftDeletedTableTest :
> Could you please add a second test where
Thanks for your advice.


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc@435
PS2, Line 435: if (FLAGS_leader_rebalancing_ignore_soft_deleted
> Shouldn't the 'leader_rebalancing_ignore_soft_deleted_tables' flag be used 
Done


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@875
PS2, Line 875: Retrieve all tables from the normalized_table_names_map_.
> nit: (I'm not that familiar in this part of the codebase, and had to lookup
Done


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@879
PS2, Line 879: 
> nit: following up on the above consideration, would it make sense to give a
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2024 03:25:26 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which may take a long time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Reviewed-on: http://gerrit.cloudera.org:8080/21411
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
4 files changed, 122 insertions(+), 19 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Marton Greber: Looks good to me, approved
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@10
PS1, Line 10: not needed to do leader rebal
> nit: not needed to do leader rebalance for
Done


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12: a configu
> configuration
Done


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12:  provid
> provides
Done


http://gerrit.cloudera.org:8080/#/c/21411/1//COMMIT_MSG@12
PS1, Line 12: patc
> patch
Done


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@90
PS1, Line 90: leader_rebalancing_ignore_soft_deleted_tables
> How about 'leader_rebalancing_ignore_soft_deleted_tables' to clarify?
Done


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@435
PS1, Line 435:     catalog_manager_->GetNormalTables(&table_infos);
> GetAllTables returns a vector related to 'table_ids_map_', when 'normal' ta
Done


http://gerrit.cloudera.org:8080/#/c/21411/1/src/kudu/master/auto_leader_rebalancer.cc@437
PS1, Line 437: (const auto& table_info : table_infos) {
> nit: for (auto table_info : table_infos) { ?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2024 10:07:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21411/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21411/3//COMMIT_MSG@11
PS3, Line 11: maybe cost a lot of time
may take a long time


http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc@586
PS3, Line 586: rebalance
nit: rebalanced


http://gerrit.cloudera.org:8080/#/c/21411/3/src/kudu/master/auto_leader_rebalancer-test.cc@592
PS3, Line 592: rebalance
nit:rebalanced



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 May 2024 12:19:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc@535
PS2, Line 535: TEST_F(LeaderRebalancerTest, TestFilterTrashedTable) {
Could you please add a second test where
FLAGS_leader_rebalancing_ignore_soft_deleted_tables = false?
Just to test both ways.


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc@435
PS2, Line 435: catalog_manager_->GetNormalTables(&table_infos);
Shouldn't the 'leader_rebalancing_ignore_soft_deleted_tables' flag be used here to decide whether to use GetAllTables() or GetNormalTables() ?


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@875
PS2, Line 875: Retrieve all normal tables, exclud soft deleted tables, not runnig tables.
nit: (I'm not that familiar in this part of the codebase, and had to lookup that we dont do any explicit exclusion here, it is a property of normalized_table_names_map_ that it contains only running and not soft-deleted tables)
Could you rephrase this, such that it is more clear? Something like:

// Retrieve all tables from the normalized_table_names_map_.
// The normalized_table_names_map_ inherently does not contain
// soft-deleted or not running tables, so no manual exclusion is needed.


http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@879
PS2, Line 879: GetNormalTables
nit: following up on the above consideration, would it make sense to give a clearer function name?
Something like: GetActiveTables() ?



-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 16 May 2024 11:38:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/158/


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 02:38:06 +0000
Gerrit-HasComments: No

[kudu-CR] Leader rebalance ignores soft deleted tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )

Change subject: Leader rebalance ignores soft deleted tables
......................................................................


Patch Set 6: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/158/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 May 2024 03:32:57 +0000
Gerrit-HasComments: No