You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/14 00:27:54 UTC

[GitHub] [helix] narendly commented on issue #895: Update listClusters() in ZkHelixAdmin

narendly commented on issue #895: Update listClusters() in ZkHelixAdmin
URL: https://github.com/apache/helix/pull/895#issuecomment-598982274
 
 
   This PR is ready to be merged, approved by @pkuwm 
   
   This PR updates getClusters() in ZkHelixAdmin in realm-aware mode. It is difficult to reason about getting all clusters - and this method, on single-realm mode, is also broken anyways because in the case users create nested clusters, this method will end up returning nothing. This update is backward-compatible for single-realm users.
   
   Ideally, users should use Metadata Store Directory Service to get the list of all clusters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org