[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #206: Build Script & General updates

[GitBox <gi...@apache.org>]

Shanedell commented on code in PR #206:
URL: https://github.com/apache/daffodil-vscode/pull/206#discussion_r915242738


##########
build/scripts/process_build.ts:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// @ts-nocheck <-- This is needed as this file is basically a JavaScript script
+//                 but with some TypeScript niceness baked in
+const fs = require('fs')
+const execSync = require('child_process').execSync
+
+function prebuild() {

Review Comment:
   So what this script is doing is replacing the OS specific commands to move `bin.LICENSE` and `bin.NOTICE` to be `LICENSE` and `NOTICE` before packaging the VSIX, then reverting them back once the VSIX is done.
   
   So the sync variants just ensure that nothing else is going to happen before this item completes its tasks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org