[GitHub] [airflow] potiuk opened a new pull request #22544: Optimize direct push workflows in GitHub Actions

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #22544:
URL: https://github.com/apache/airflow/pull/22544


   When the build is run via direct push to apache airflow repo
   we do not need to run two separate workflows. The "push" workflow
   is never a "pull request from fork" so it should have
   the capability to build and push images to registry.
   
   This allows the committers to make direct push requests to run PRs
   that are actually running the build without having to merge
   build-image.yml first.
   
   This is cool because committers can simply push a branch to apache
   and test if it works with some build image changes that otherwise
   would require to push to `main` of an apache-airflow fork.
   
   Another advantage is that merge and schedule builds do not run two
   separate workflows - both building the image and running tests is done
   in the same workflow (and the build-image workflow is not started)
   This saves some build time on "wait for CI images" and
   "wait for PROD images" jobs - because in merge builds and
   schedule builds they only start after the images are actually
   built.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #22544: Optimize direct push workflows in GitHub Actions

[GitBox <gi...@apache.org>]

potiuk closed pull request #22544:
URL: https://github.com/apache/airflow/pull/22544


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22544: Optimize direct push workflows in GitHub Actions

[GitBox <gi...@apache.org>]

potiuk commented on pull request #22544:
URL: https://github.com/apache/airflow/pull/22544#issuecomment-1079764921


   Creating "fork PR" to test it too :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org