You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/01 04:38:13 UTC
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Hello Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4194
to review the following change.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
ts_tablet_manager: set status message after failed tablet copy
I noticed in a test cluster that a tablet copy had failed, and ksck was
reporting the state as:
b314b10216d74c07ab9da974671137db (ve0136.halxg.cloudera.com:7050): bad state
State: NOT_STARTED
Data state: TABLET_DATA_TOMBSTONED
Last status: TabletCopy: Downloading block 4611685870251245460 (2342/33956)
This was rather confusing, because it claimed it was downloading a
block, and also claimed to be tombstoned at the same time (rather than
being in the COPYING state).
This fixes the failure case to set the status message properly.
Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
3 files changed, 17 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/4194/1
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4194
to look at the new patch set (#3).
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
ts_tablet_manager: set status message after failed tablet copy
I noticed in a test cluster that a tablet copy had failed, and ksck was
reporting the state as:
b314b10216d74c07ab9da974671137db (ve0136.halxg.cloudera.com:7050): bad state
State: NOT_STARTED
Data state: TABLET_DATA_TOMBSTONED
Last status: TabletCopy: Downloading block 4611685870251245460 (2342/33956)
This was rather confusing, because it claimed it was downloading a
block, and also claimed to be tombstoned at the same time (rather than
being in the COPYING state).
This fixes the failure case to set the status message properly.
Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
3 files changed, 18 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/4194/3
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
ts_tablet_manager: set status message after failed tablet copy
I noticed in a test cluster that a tablet copy had failed, and ksck was
reporting the state as:
b314b10216d74c07ab9da974671137db (ve0136.halxg.cloudera.com:7050): bad state
State: NOT_STARTED
Data state: TABLET_DATA_TOMBSTONED
Last status: TabletCopy: Downloading block 4611685870251245460 (2342/33956)
This was rather confusing, because it claimed it was downloading a
block, and also claimed to be tombstoned at the same time (rather than
being in the COPYING state).
This fixes the failure case to set the status message properly.
Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Reviewed-on: http://gerrit.cloudera.org:8080/4194
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
3 files changed, 18 insertions(+), 10 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/3182/
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3177/
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ts tablet manager: set status message after failed tablet copy
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ts_tablet_manager: set status message after failed tablet copy
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3176/
--
To view, visit http://gerrit.cloudera.org:8080/4194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ecd45dacec4ea329a0f0dd236e52bc603f9b93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No