You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/09/04 09:19:43 UTC
[I] [Studio] Remove Kubernetes certificate lifecycle management [rocketmq-dashboard]
Aias00 opened a new issue, #3128:
URL: https://github.com/apache/rocketmq-dashboard/issues/3128
### Background
The Studio K8s certificate page stores local configuration and metadata only. It is not connected to Kubernetes Secrets, cert-manager `Certificate` resources, or any Kubernetes client. Maintainer review concluded that Kubernetes certificate lifecycle management is outside the RocketMQ dashboard scope.
The current `/api/k8s-certs/renew` implementation only advances locally stored validity dates and can therefore imply a renewal that never happened in Kubernetes. Separate enhancement branches add PEM replacement and mTLS key matching, but consolidating more certificate lifecycle logic would move the dashboard further away from RocketMQ operations.
### Scope
- Remove the local certificate renewal endpoint, DTO, service behavior, web API/service wrapper, mocks, tests, and audit presentation entries.
- Remove documentation claims that Studio renews Kubernetes certificates.
- Retire the proposed Kubernetes certificate provider/lifecycle design.
- Keep the existing Studio-local certificate configuration surface: list, create, update, delete, PEM metadata parsing, expiry/status display, and NameServer `k8sId` selection.
- Keep the UI explicit that these records are Studio-local configuration and do not modify Kubernetes resources.
### Non-goals
- Removing the pre-existing K8s certificate page or database table; that can be handled by a separate cleanup proposal.
- Adding a Kubernetes client, cert-manager integration, Secret inventory, renewal, or deletion.
- Changing NameServer K8s metadata fields.
### Acceptance criteria
- `POST /api/k8s-certs/renew` is no longer exposed.
- No frontend or mock service exports a certificate renewal operation.
- No K8s certificate renewal audit label remains.
- README, API documentation, and page messaging describe local configuration only.
- The provider lifecycle proposal is removed so it is not mistaken for an active roadmap.
- Targeted server and web tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio] Remove Kubernetes certificate lifecycle management [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #3128:
URL: https://github.com/apache/rocketmq-dashboard/issues/3128#issuecomment-5566344072
Resolved by #3130 (merged into `rocketmq-studio` as 6df87144).
All acceptance criteria are met: `POST /api/k8s-certs/renew` is no longer exposed (a regression test asserts 404), no frontend or mock service exports a renewal operation, the `RENEW_K8S_CERTIFICATE` audit label is gone, README / api-spec / page messaging now describe Studio-local configuration only, and `docs/kubernetes-certificate-provider.md` is removed so the provider lifecycle proposal is no longer mistaken for an active roadmap.
Note the deliberately retained surface, as listed in the issue's non-goals: the certificate page, its list/create/update/delete endpoints, and the `rmq_k8s_certificate` table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio] Remove Kubernetes certificate lifecycle management [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #3128:
URL: https://github.com/apache/rocketmq-dashboard/issues/3128#issuecomment-5538931877
The K8s certificate lifecycle management code exists in the Studio module (confirmed: `K8sCertControllerTest`, `K8sCertServiceTest`, `MybatisPlusK8sCertRepositoryTest`). This functionality is arguably outside the scope of a dashboard/management console and could be handled by dedicated K8s tooling (cert-manager, Helm charts, or the rocketmq-operator).
**Assessment:**
- Removing this code reduces maintenance burden and keeps Studio focused on its core purpose (cluster monitoring and management)
- Before removal, verify that no other Studio features depend on the K8s cert APIs
- Consider deprecation notice in a release before full removal
This is a reasonable cleanup. Whether to proceed is a maintainer decision — flagging for discussion.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio] Remove Kubernetes certificate lifecycle management [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #3128: [Studio] Remove Kubernetes certificate lifecycle management
URL: https://github.com/apache/rocketmq-dashboard/issues/3128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org