You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/01/09 07:35:55 UTC

Review Request 55332: Added 'message.proto' for OCI store.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55332/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added 'message.proto' for OCI store.


Diffs
-----

  src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
  src/slave/containerizer/mesos/provisioner/oci/message.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/message.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/55332/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55332: Added 'message.proto' for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55332/
-----------------------------------------------------------

(Updated March 30, 2017, 9:59 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Replaced `config_id` and `layer_ids` with `manifest_id` in the `Image` message.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added 'message.proto' for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt b67b512cafd90558abf712a872310ab913fa38ae 
  src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e 
  src/slave/containerizer/mesos/provisioner/oci/message.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/message.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/55332/diff/3/

Changes: https://reviews.apache.org/r/55332/diff/2-3/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55332: Added 'message.proto' for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55332/
-----------------------------------------------------------

(Updated Feb. 1, 2017, 9:20 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Replaced 'config' with 'config_id'.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added 'message.proto' for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
  src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
  src/slave/containerizer/mesos/provisioner/oci/message.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/message.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/55332/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55332: Added 'message.proto' for OCI store.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55332/#review160877
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Jan. 8, 2017, 11:35 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55332/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'message.proto' for OCI store.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
>   src/slave/containerizer/mesos/provisioner/oci/message.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/message.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55332/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>