You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/23 09:43:21 UTC

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1238: fix: namespace_selector invalid when restarting

lingsamuel commented on code in PR #1238:
URL: https://github.com/apache/apisix-ingress-controller/pull/1238#discussion_r952392003


##########
test/e2e/scaffold/ingress.go:
##########
@@ -428,13 +428,17 @@ func (s *Scaffold) newIngressAPISIXController() error {
 	})
 
 	var ingressAPISIXDeployment string
-	label := fmt.Sprintf("apisix.ingress.watch=%s", s.namespace)
+	label := "\"\""

Review Comment:
   `` `""` `` would be clearer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org