You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "diaohancai (via GitHub)" <gi...@apache.org> on 2023/09/17 08:17:56 UTC
[GitHub] [incubator-hugegraph-computer] diaohancai opened a new pull request, #268: fix #267
diaohancai opened a new pull request, #268:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/268
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR will fix/close a issue, type the message "close xxx" (xxx is the link of related issue) in the content, github will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after published)
-->
## Purpose of the PR
- close #267
## Main Changes
Correct incorrect comment.
## Verifying these changes
<!-- Please pick the proper options below -->
- [X] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows.
<!-- Please provide more details about verification
For example:
- If you test manually, please provide related screenshot.
-->
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [X] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [X] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] codecov[bot] commented on pull request #268: chore: correct incorrect comment
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/268#issuecomment-1726784198
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#268](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec06513) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/fdb4621330d76d2d74f5162864fff28365fa735f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fdb4621) will **increase** coverage by `0.05%`.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #268 +/- ##
============================================
+ Coverage 85.83% 85.89% +0.05%
- Complexity 3235 3236 +1
============================================
Files 344 344
Lines 12115 12115
Branches 1092 1092
============================================
+ Hits 10399 10406 +7
+ Misses 1194 1187 -7
Partials 522 522
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hugegraph/computer/core/common/ContainerInfo.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvY29tbW9uL0NvbnRhaW5lckluZm8uamF2YQ==) | `90.90% <ø> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/268/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] simon824 merged pull request #268: chore: correct incorrect comment
Posted by "simon824 (via GitHub)" <gi...@apache.org>.
simon824 merged PR #268:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] simon824 commented on pull request #268: chore: correct incorrect comment
Posted by "simon824 (via GitHub)" <gi...@apache.org>.
simon824 commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/268#issuecomment-1724776930
By the way, [hugegraph-computer ci](https://github.com/apache/incubator-hugegraph-computer/actions/runs/6212492588/job/16873802692?pr=268) was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] Radeity commented on pull request #268: chore: correct incorrect comment
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/268#issuecomment-1727417449
> By the way, [hugegraph-computer ci](https://github.com/apache/incubator-hugegraph-computer/actions/runs/6212492588/job/16873802692?pr=268) was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity
I've checked error logs and find that there's an unexpected state change, we expect to receive `CANCELLED`, but receive some states else, which confuse me that what's the other possible state changes? Also, may I ask why we sleep 1.5s after calling `cancelJob`? cc @coderzc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org