You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/17 18:41:07 UTC
[GitHub] [thrift] fishy opened a new pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
fishy opened a new pull request #2494:
URL: https://github.com/apache/thrift/pull/2494
Client: go
Follow up on d582a8614, do the same thing on TFramedTransport.
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy merged pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
fishy merged pull request #2494:
URL: https://github.com/apache/thrift/pull/2494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2494:
URL: https://github.com/apache/thrift/pull/2494#issuecomment-1006122491
> Wait I noticed a bug in the TFrameTransport implementation. Fixing now.
I read my pre-holidays code wrong and thought I introduced a bug to break small reads, which turns out to be fine, but I added a test to make sure of it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2494:
URL: https://github.com/apache/thrift/pull/2494#issuecomment-1006105146
The THeader change has been running in our production for one day without issues. Merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2494:
URL: https://github.com/apache/thrift/pull/2494#issuecomment-1004915887
> LGTM. Apologies for the late review, I was away for a while.
nah it's ok :) I'm waiting for the year end code freeze to end so we can actually deploy the THeader one to production first anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2494:
URL: https://github.com/apache/thrift/pull/2494#issuecomment-1005200157
> I'm waiting for the year end code freeze to end
Cold enough it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2494: THRIFT-5490: Use pooled buffer for TFramedTransport
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2494:
URL: https://github.com/apache/thrift/pull/2494#issuecomment-1006105825
Wait I noticed a bug in the TFrameTransport implementation. Fixing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org