You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/24 18:36:00 UTC
[jira] [Commented] (THRIFT-4753) Re-version master to 0.13.0 (next
anticipated release number) and clean up distribution
[ https://issues.apache.org/jira/browse/THRIFT-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751415#comment-16751415 ]
James E. King III commented on THRIFT-4753:
-------------------------------------------
[~jensg] The distribution (that nobody unpacked to look at, including myself) contains object and binaries in netcore and others, like js/node_modules too... here's something to look out for in the EXTRA_DIST in netstd. I'm cleaning this up in a PR...
{noformat}
thrift-1.0.0/lib/netcore/Tests/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/CassandraTest.thrift
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/project.assets.json
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Thrift.PublicInterfaces.Compile.Tests.csproj.nuget.g.targets
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Thrift.PublicInterfaces.Compile.Tests.csproj.nuget.g.props
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.csproj.CoreCompileInputs.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.csproj.FileListAbsolute.txt
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.assets.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.csproj.CopyComplete
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.pdb
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.csprojAssemblyReference.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.dll
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.AssemblyInfo.cs
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.AssemblyInfoInputs.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/obj/Thrift.PublicInterfaces.Compile.Tests.csproj.nuget.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/Properties/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/Properties/AssemblyInfo.cs
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.dll
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.pdb
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.dll
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.PublicInterfaces.Compile.Tests.deps.json
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.pdb
thrift-1.0.0/lib/netcore/Tests/Thrift.PublicInterfaces.Compile.Tests/bin/Debug/netcoreapp2.0/Thrift.dll.config
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/Thrift.IntegrationTests.csproj
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/Thrift.IntegrationTests.csproj.nuget.g.targets
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/project.assets.json
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/Thrift.IntegrationTests.csproj.nuget.cache
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/Debug/
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/Debug/netcoreapp2.0/
thrift-1.0.0/lib/netcore/Tests/Thrift.IntegrationTests/obj/Debug/netcoreapp2.0/Thrift.IntegrationTests.Program.cs
{noformat}
> Re-version master to 0.13.0 (next anticipated release number) and clean up distribution
> ---------------------------------------------------------------------------------------
>
> Key: THRIFT-4753
> URL: https://issues.apache.org/jira/browse/THRIFT-4753
> Project: Thrift
> Issue Type: Task
> Components: Build Process
> Affects Versions: 0.13.0
> Reporter: James E. King III
> Assignee: James E. King III
> Priority: Major
>
> I found that the distribution includes lib/js/node_modules which is unnecessary and there are a number of other unnecessary files in the repo that can be cleaned up. Also the "make clean" processing leverages a shell script that should be unnecessary, as long as we use the automake directives for cleaning up:
> https://www.gnu.org/software/automake/manual/html_node/Clean.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)