You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/08 11:51:47 UTC

[GitHub] [camel] Sonicsupremacy opened a new pull request #4175: CAMEL-15514: Add auto generation of operation IDs

Sonicsupremacy opened a new pull request #4175:
URL: https://github.com/apache/camel/pull/4175


   Since operationId is an optional parameter as defined by OpenApi 3 standard, I think that improving the component to be able to auto generate missing operationIds from operation path and http method would benefit users of camel-rest-openapi component.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] Sonicsupremacy commented on pull request #4175: CAMEL-15514: Add auto generation of operation IDs

Posted by GitBox <gi...@apache.org>.
Sonicsupremacy commented on pull request #4175:
URL: https://github.com/apache/camel/pull/4175#issuecomment-689418351


   Dashes are now used for separating words.
   
   @davsclaus it should not be possible to generate duplicates. OpenApi standard states that all paths are relative to api server url and paths also can not be nested. That guarantees that there can be no duplicate paths. Any base paths are specified at the api server url level.
   
   To expand on your example:
   paths
   - user
      GET {id}
   - order
      GET {id}
   
   would be defined in api specification as:
   - /user/{id} and
   - /order/{id}


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #4175: CAMEL-15514: Add auto generation of operation IDs

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4175:
URL: https://github.com/apache/camel/pull/4175


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4175: CAMEL-15514: Add auto generation of operation IDs

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4175:
URL: https://github.com/apache/camel/pull/4175#issuecomment-689320798


   I wonder if you can end up generate duplicates if that path doesnt take the base path into account eg
   
   - user
        GET {id}
   - order
         GET {id}
   
   Where user and order are base path, and the the path is {id}, then you have 2 operations with get-id
   
   it should be
   
   get-user-id
   get-order-id
   
   And can the id use dash or underscore to seperate the words nicely, otherwise its generated as getid, getuserid etc
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org