You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Korbinian Bachl <ko...@whiskyworld.de> on 2007/01/01 18:28:03 UTC
missing decoding in IndexedParamUrlCodingStrategy in 2.0
Hi,
i noticed that wicket encodes all PageParameters for a page using the
IndexedParamUrlCodingStrategy, but never decodes it, so you get the input
raw, wich is opposite of the behaviour of
BookmarkablePageRequestTargetUrlCodingStrategy where all parameters are
encoded and decoded completely.
Regards,
Korbinian
PS: Happy New Year !
AW: missing decoding in IndexedParamUrlCodingStrategy in 2.0
Posted by Korbinian Bachl <ko...@whiskyworld.de>.
Done, wicket-193 - which is quite similar to wicket-77... a complete rework
of the cycle might be really, so you could also get rid of the "wicket" word
in usual URLs if someone doenst like this...
Regards
PS: had you a chance to look at the unit-test I sent you: i still dont know
how do have a "MockApplication" set up...
> -----Ursprüngliche Nachricht-----
> Von: Johan Compagner [mailto:jcompagner@gmail.com]
> Gesendet: Dienstag, 2. Januar 2007 09:19
> An: wicket-dev@incubator.apache.org
> Betreff: Re: missing decoding in IndexedParamUrlCodingStrategy in 2.0
>
> make a jira ticket for this.
> We should look at the complete encode/decode story anyway.
> Now it is done in numerous places some like
> String.replace("&", "&") and here a decode there a
> encode. This should all be done for the complete url itself i
> think in one place (instead per parameter or value)
>
> johan
>
>
> On 1/1/07, Korbinian Bachl <ko...@whiskyworld.de> wrote:
> >
> > Hi,
> >
> > i noticed that wicket encodes all PageParameters for a page
> using the
> > IndexedParamUrlCodingStrategy, but never decodes it, so you get the
> > input raw, wich is opposite of the behaviour of
> > BookmarkablePageRequestTargetUrlCodingStrategy where all parameters
> > are encoded and decoded completely.
> >
> > Regards,
> >
> > Korbinian
> >
> > PS: Happy New Year !
> >
> >
>
Re: missing decoding in IndexedParamUrlCodingStrategy in 2.0
Posted by Johan Compagner <jc...@gmail.com>.
make a jira ticket for this.
We should look at the complete encode/decode story anyway. Now it is done in
numerous places some like String.replace("&", "&") and here
a decode there a encode. This should all be done for the complete url itself
i think in one place (instead per parameter or value)
johan
On 1/1/07, Korbinian Bachl <ko...@whiskyworld.de> wrote:
>
> Hi,
>
> i noticed that wicket encodes all PageParameters for a page using the
> IndexedParamUrlCodingStrategy, but never decodes it, so you get the input
> raw, wich is opposite of the behaviour of
> BookmarkablePageRequestTargetUrlCodingStrategy where all parameters are
> encoded and decoded completely.
>
> Regards,
>
> Korbinian
>
> PS: Happy New Year !
>
>