You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/05 23:00:44 UTC
[GitHub] [spark] mukulmurthy commented on a change in pull request #26771:
[SPARK-30143][SS] Add a timeout on stopping a streaming query
mukulmurthy commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r354587841
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1258,6 +1258,14 @@ object SQLConf {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefault(10L)
+ val STREAMING_STOP_TIMEOUT =
Review comment:
Should this be STREAMING_STOP_TIMEOUT_MS or _MILLIS, or is that not the spark way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org