[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422076#comment-16422076 ] 

Shalin Shekhar Mangar commented on SOLR-12133:
----------------------------------------------

The testNodeMarkersRegistration failures are also due to a race condition in the test. The test asserts that a znode is created on node added and node lost events respectively which is then deleted after the trigger fires. But the znode is deleted by the trigger thread whereas the actions are executed by the action executor asynchronously. So sometimes the marker znodes can be deleted even before the test has a chance to assert that they exist. I think we can fix it by using a listener which is executed in the same thread as the trigger and perform the assert there.

> TriggerIntegrationTest fails too easily.
> ----------------------------------------
>
>                 Key: SOLR-12133
>                 URL: https://issues.apache.org/jira/browse/SOLR-12133
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>         Attachments: SOLR-12133.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org