You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2015/08/28 04:09:46 UTC

[jira] [Updated] (MATH-1259) Negative max in class Incrementor

     [ https://issues.apache.org/jira/browse/MATH-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles updated MATH-1259:
-------------------------
    Attachment: IntegerSequence.java

To avoid compatibility issues, I propose to implement the correct functionality in a new class (see attached file).
Please review.

The old {{Incrementor}} would be deprecated in 3.6 and removed in 4.0.


> Negative max in class Incrementor
> ---------------------------------
>
>                 Key: MATH-1259
>                 URL: https://issues.apache.org/jira/browse/MATH-1259
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Gunel Jahangirova
>            Priority: Minor
>         Attachments: IntegerSequence.java
>
>
> In class Incrementor in the org.apache.commons.math4.util package it is possible to pass a negative number for the max variable. Given that the count variable is initialised to 0 by default, it means that canIncrement() method will always return false. 
> I wonder whether it is an acceptable behaviour, given that documentation says that Incrementor is a utility that increments a counter until a maximum is reached. And in the case of negative max this maximum is not reachable at all. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)