You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:31:42 UTC
[GitHub] [bookkeeper] dlg99 opened a new pull request #3130: Bringing back maven build
dlg99 opened a new pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130
### Motivation
Bringing back maven build as per [conversation on ML](https://lists.apache.org/thread/wplcncz160d8z9wzmw1d68mcbrnjkf0b).
### Changes
Reverted change that deleted mvn build, fixed dependencies that were changed after the mvn deletion, suppressed warnings in tests (gradle build seems to ignore the warnings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1074877845
I built the package locally and run "localbookie" and a small bookkeeper cluster (tested with BKVM).
Everything looks good.
I am now running all the tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1075542061
Problems with the docker image for tests
Error: Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project current-version-image: Missing Dockerfile in context directory: /home/runner/work/bookkeeper/bookkeeper/tests/docker-images/current-version-image -> [Help 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1075528590
@nicoloboschi @eolivelli I could not just revert the changes for the GH actions because there commit after that. I did the changes manually/picked them from branch 4.14 mostly. I left javadoc generation with gradle. Backwards compat tests also left running with gradle, plus added one action that simply builds everything with gradle but does not run tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1075265205
Unit tests seem to pass locally (I didn't run integration tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 edited a comment on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
dlg99 edited a comment on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1076874469
I fixed `CompactionByEntriesWithMetadataCacheTest` in this PR because it was failing rather consistently.
The cases that were failing pass when I ran them one-by-one, it is possible gradle re-runs the failed tests differently from maven hence it was not as noticeable there.
`org.apache.bookkeeper.test.BookieZKExpireTest` flakes on CI ("Remaining Tests") but I cannot repro it locally and it finally passed on the re-run.
@eolivelli @nicoloboschi Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1074877022
Apache RAT fails due to "site3" directory, please add the exclusion:
```
diff --git a/pom.xml b/pom.xml
index aa1cb6f62..e7108f889 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1014,6 +1014,7 @@
<!-- Website -->
<exclude>site/**</exclude>
<exclude>site2/**</exclude>
+ <exclude>site3/**</exclude>
<!-- Thrift generated files -->
<exclude>**/org/apache/distributedlog/thrift/*</exclude>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1075541405
There are problems with the license check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1075984109
Very good!
I see only CompactionByEntriesWithoutMetadataCacheTest is failing.
It is not related to Maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #3130: Bringing back maven build
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #3130:
URL: https://github.com/apache/bookkeeper/pull/3130#issuecomment-1076874469
I fixed `CompactionByEntriesWithMetadataCacheTest` in this PR because it was failing rather consistently.
The cases that were failing pass when I ran them one-by-one, it is possible gradle re-runs the failed tests differently from maven hence it was not as noticeable there.
`org.apache.bookkeeper.test.BookieZKExpireTest` flakes on CI but I cannot repro it locally and it finally passed on the re-run.
@eolivelli @nicoloboschi Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org