You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/29 09:05:18 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request #16468: Stop writing supported for DistSQL
soulasuna opened a new pull request #16468:
URL: https://github.com/apache/shardingsphere/pull/16468
## Stop writing supported for DistSQL
Related to #16269.
Changes proposed in this pull request:
- Stop writing supported for `DistSQL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a change in pull request #16468: Stop writing supported for DistSQL
Posted by GitBox <gi...@apache.org>.
sandynz commented on a change in pull request #16468:
URL: https://github.com/apache/shardingsphere/pull/16468#discussion_r837257227
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/DistSQLBackendHandlerFactory.java
##########
@@ -51,6 +53,7 @@ public static TextProtocolBackendHandler newInstance(final DatabaseType database
if (sqlStatement instanceof RQLStatement) {
return RQLBackendHandlerFactory.newInstance((RQLStatement) sqlStatement, connectionSession);
}
+ checkLockedSchema(connectionSession);
if (sqlStatement instanceof RDLStatement) {
Review comment:
scaling DistSQL should be executable, they're RAL.
But I'm not sure whether other RAL could be executable or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #16468: Stop writing supported for DistSQL
Posted by GitBox <gi...@apache.org>.
sandynz merged pull request #16468:
URL: https://github.com/apache/shardingsphere/pull/16468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on a change in pull request #16468: Stop writing supported for DistSQL
Posted by GitBox <gi...@apache.org>.
soulasuna commented on a change in pull request #16468:
URL: https://github.com/apache/shardingsphere/pull/16468#discussion_r837282745
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/DistSQLBackendHandlerFactory.java
##########
@@ -51,6 +53,7 @@ public static TextProtocolBackendHandler newInstance(final DatabaseType database
if (sqlStatement instanceof RQLStatement) {
return RQLBackendHandlerFactory.newInstance((RQLStatement) sqlStatement, connectionSession);
}
+ checkLockedSchema(connectionSession);
if (sqlStatement instanceof RDLStatement) {
Review comment:
I will optimize the type of statement intercepted `QueryableRALStatement`, `QueryableScalingRALStatement`, `UpdatableScalingRALStatement` they will be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org