You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/01/13 01:37:08 UTC

[GitHub] [beam] lostluck commented on a change in pull request #16487: [BEAM-13399] Move service liveness polling to ExpansionServiceRunner type

lostluck commented on a change in pull request #16487:
URL: https://github.com/apache/beam/pull/16487#discussion_r783565635



##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go
##########
@@ -60,11 +63,24 @@ func (e *ExpansionServiceRunner) String() string {
 }
 
 // Endpoint returns the formatted endpoint the ExpansionServiceRunner is set to start the expansion
-// service on. 
+// service on.
 func (e *ExpansionServiceRunner) Endpoint() string {
 	return "localhost:" + e.servicePort
 }
 
+func (e *ExpansionServiceRunner) pingEndpoint(timeout time.Duration) error {

Review comment:
       Notionally this will mean things take a bit longer since we're connecting twice (here, and actual use), but It's probably fine until we determine we don't need to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org