[GitHub] [avro] radai-rosenblatt commented on a change in pull request #1342: AVRO-3212: fix specification to allow doc in fixed types

[GitBox <gi...@apache.org>]

radai-rosenblatt commented on a change in pull request #1342:
URL: https://github.com/apache/avro/pull/1342#discussion_r712285901



##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -254,14 +254,16 @@
         <section>
           <title>Fixed</title>
           <p>Fixed uses the type name <code>"fixed"</code> and supports
-          two attributes:</p>
+          the following attributes:</p>
 	  <ul>
 	    <li><code>name</code>: a string naming this fixed (required).</li>
 	    <li><em>namespace</em>, a string that qualifies the name;</li>

Review comment:
       change <em> to <code> for namespace - at least I cant think of a reason why it's different?
   i agree namespace should be marked optional (it is. it is also ignored is name has dots in it), but will leave that to a committer to decide




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org