[GitHub] [apisix] leslie-tsang commented on a diff in pull request #9453: build: added `check-rust` in Makefile to see if Rust is installed before installing deps

["leslie-tsang (via GitHub)" <gi...@apache.org>]

leslie-tsang commented on code in PR #9453:
URL: https://github.com/apache/apisix/pull/9453#discussion_r1190563669


##########
Makefile:
##########
@@ -147,10 +147,17 @@ help:
 	fi
 	@echo
 
+### check-rust : check if Rust is installed in the environment
+.PHONY: check-rust
+check-rust:
+	@if ! which rustc >/dev/null; then \

Review Comment:
   ```suggestion
   	@if [ ! which rustc >/dev/null ]; then \
   ```



##########
Makefile:
##########
@@ -147,10 +147,17 @@ help:
 	fi
 	@echo
 
+### check-rust : check if Rust is installed in the environment
+.PHONY: check-rust
+check-rust:
+	@if ! which rustc >/dev/null; then \
+		echo "ERROR: Rust is not installed. Please install Rust before continuing." >&2; \
+		exit 1; \
+	fi;

Review Comment:
   ```suggestion
   	fi;
   
   ```
   Need two blank line between targets. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org