You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/11/17 02:12:05 UTC
Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
Bugs: AMBARI-8346
https://issues.apache.org/jira/browse/AMBARI-8346
Repository: ambari
Description
-------
Added schema and altered code and tests to support creating line-items for an upgrade
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceDefinitionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
Diff: https://reviews.apache.org/r/28112/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:25.681s
[INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
[INFO] Final Memory: 29M/629M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61738
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103609>
Rather than adding 1 to `i` here for each iteration of the loop, wouldn't you simply start `i` at 1 (rather than 0) when you initialize it?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103610>
See previous comment on similar scenario.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103614>
Wouldn't the use of polymorphism be cleaner here?
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java
<https://reviews.apache.org/r/28112/#comment103617>
Why not inline this like in PercentBatch... or vice versa?
- Robert Levas
On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:49 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 17, 2014, 7:41 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 354
> > <https://reviews.apache.org/r/28112/diff/2/?file=765813#file765813line354>
> >
> > Is patch valid (for commit) without persisting request?
Yes, I have another JIRA for creating request/stage/tasks that's coming up.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61714
-----------------------------------------------------------
On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:49 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61714
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103555>
Is patch valid (for commit) without persisting request?
- Dmitro Lisnichenko
On Nov. 17, 2014, 11:49 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 11:49 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61805
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 17, 2014, 6:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 17, 2014, 3:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java, line 166
> > <https://reviews.apache.org/r/28112/diff/2/?file=765823#file765823line166>
> >
> > Through the upgrade, the FK is named, however, through the -Create.sql script, it is given an auto generated name.
I agree in general, but our implementation has a big disparity anyway just having the scripts. This won't be isolated to upgrade* tables.
> On Nov. 17, 2014, 3:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 232
> > <https://reviews.apache.org/r/28112/diff/2/?file=765813#file765813line232>
> >
> > Should we also check for empty string?
Nah :)
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61767
-----------------------------------------------------------
On Nov. 17, 2014, 1:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 1:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61767
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103646>
Should we also check for empty string?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103651>
On a related note, automatic updates should also update decomission hosts, but we may want to warn the user about this and track it through a UI jira.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103684>
Is this hardcoded just for the sake of a working example?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103685>
Can you explain the logic here?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103687>
Shouldn't the set be cleared after adding it?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
<https://reviews.apache.org/r/28112/#comment103690>
Through the upgrade, the FK is named, however, through the -Create.sql script, it is given an auto generated name.
- Alejandro Fernandez
On Nov. 17, 2014, 6:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61799
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103697>
Fixed in diff #3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103696>
This is to support the "minimal downtime" portion. So to do so, all the hosts need to be acted upon in groups instead of all together.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103698>
No, because I just create a new one.
- Nate Cole
On Nov. 17, 2014, 1:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 1:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61776
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Nov. 17, 2014, 1:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 1:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61788
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 17, 2014, 6:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/
-----------------------------------------------------------
(Updated Nov. 17, 2014, 1:56 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
Changes
-------
Updated for comments
Bugs: AMBARI-8346
https://issues.apache.org/jira/browse/AMBARI-8346
Repository: ambari
Description
-------
Added schema and altered code and tests to support creating line-items for an upgrade
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java cbd2e79
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java e8e2c07
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java b95b616
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 551cac3
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
Diff: https://reviews.apache.org/r/28112/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:25.681s
[INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
[INFO] Final Memory: 29M/629M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/#review61746
-----------------------------------------------------------
Thanks for the review!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28112/#comment103641>
Absolutely, this is leftover from all the experimentation
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java
<https://reviews.apache.org/r/28112/#comment103625>
It can't be inlined because it needs to be serialized into JSON, and for that I need the field. Actually, this is a bug in PERCENT that it _shouldn't_ be in lined.
- Nate Cole
On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28112/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 6:49 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8346
> https://issues.apache.org/jira/browse/AMBARI-8346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added schema and altered code and tests to support creating line-items for an upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
> ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
>
> Diff: https://reviews.apache.org/r/28112/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:25.681s
> [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
> [INFO] Final Memory: 29M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28112: Upgrade Execute: define db schema to store
upgrade artifacts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28112/
-----------------------------------------------------------
(Updated Nov. 17, 2014, 6:49 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
Changes
-------
Fixed patch for assertions, and renamed new test (was implying that the ResourceDefinition was getting tested when it's in fact the ResourceProvider)
Bugs: AMBARI-8346
https://issues.apache.org/jira/browse/AMBARI-8346
Repository: ambari
Description
-------
Added schema and altered code and tests to support creating line-items for an upgrade
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java baf7401
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d4d20fd
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 55904f3
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 912f2cf
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java d3376dd
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 30dceb0
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java a4b2fc5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 2677d7c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java ee92394
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java 2c3604e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 3ebde36
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a
ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ec402c0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 194f424
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
Diff: https://reviews.apache.org/r/28112/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:25.681s
[INFO] Finished at: Sun Nov 16 19:54:21 EST 2014
[INFO] Final Memory: 29M/629M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole