You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ibatis.apache.org by "Ron Grabowski (JIRA)" <ib...@incubator.apache.org> on 2005/07/09 08:49:09 UTC
[jira] Created: (IBATISNET-89) CacheKey.Equals(object) does not check _statementName for equality
CacheKey.Equals(object) does not check _statementName for equality
------------------------------------------------------------------
Key: IBATISNET-89
URL: http://issues.apache.org/jira/browse/IBATISNET-89
Project: iBatis for .NET
Type: Bug
Components: DataMapper
Reporter: Ron Grabowski
Priority: Trivial
The overloaded Equals method checks all the private properties for equality except for _statementName. The last couple lines of the method are:
if (_sql != null ? !_sql.Equals(cacheKey._sql) : cacheKey._sql != null) return false;
return true;
They might need to be:
if (_sql != null ? !_sql.Equals(cacheKey._sql) : cacheKey._sql != null) return false;
if (_statementName != null ? !_statementName.Equals(cacheKey._statementName) : cacheKey._statementName != null) return false;
return true;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (IBATISNET-89) CacheKey.Equals(object) does not check _statementName for equality
Posted by "Gilles Bayon (JIRA)" <ib...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/IBATISNET-89?page=all ]
Gilles Bayon closed IBATISNET-89:
---------------------------------
Fix Version: DataMapper 1.3
Resolution: Won't Fix
Assign To: Gilles Bayon
A Cache is attached to one Statement so we don't need to included the statement id in the Equals implemantation.
> CacheKey.Equals(object) does not check _statementName for equality
> ------------------------------------------------------------------
>
> Key: IBATISNET-89
> URL: http://issues.apache.org/jira/browse/IBATISNET-89
> Project: iBatis for .NET
> Type: Bug
> Components: DataMapper
> Reporter: Ron Grabowski
> Assignee: Gilles Bayon
> Priority: Trivial
> Fix For: DataMapper 1.3
>
> The overloaded Equals method checks all the private properties for equality except for _statementName. The last couple lines of the method are:
> if (_sql != null ? !_sql.Equals(cacheKey._sql) : cacheKey._sql != null) return false;
> return true;
> They might need to be:
> if (_sql != null ? !_sql.Equals(cacheKey._sql) : cacheKey._sql != null) return false;
> if (_statementName != null ? !_statementName.Equals(cacheKey._statementName) : cacheKey._statementName != null) return false;
> return true;
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira