You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/05 09:17:00 UTC
[jira] [Commented] (PARQUET-1309) Parquet Java uses incorrect stats
and dictionary filter properties
[ https://issues.apache.org/jira/browse/PARQUET-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501513#comment-16501513 ]
ASF GitHub Bot commented on PARQUET-1309:
-----------------------------------------
gszadovszky closed pull request #490: PARQUET-1309: Parquet Java uses incorrect stats and dictionary filter properties
URL: https://github.com/apache/parquet-mr/pull/490
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java b/parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java
index 8d3e48dd1..b8f481e8a 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java
@@ -80,8 +80,8 @@ public static Builder builder(Configuration conf) {
public Builder(Configuration conf) {
this.conf = conf;
useSignedStringMinMax(conf.getBoolean("parquet.strings.signed-min-max.enabled", false));
- useDictionaryFilter(conf.getBoolean(STATS_FILTERING_ENABLED, true));
- useStatsFilter(conf.getBoolean(DICTIONARY_FILTERING_ENABLED, true));
+ useDictionaryFilter(conf.getBoolean(DICTIONARY_FILTERING_ENABLED, true));
+ useStatsFilter(conf.getBoolean(STATS_FILTERING_ENABLED, true));
useRecordFilter(conf.getBoolean(RECORD_FILTERING_ENABLED, true));
withCodecFactory(HadoopCodecs.newFactory(conf, 0));
withRecordFilter(getFilter(conf));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Parquet Java uses incorrect stats and dictionary filter properties
> ------------------------------------------------------------------
>
> Key: PARQUET-1309
> URL: https://issues.apache.org/jira/browse/PARQUET-1309
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Reporter: Ryan Blue
> Assignee: Gabor Szadovszky
> Priority: Major
> Fix For: 1.10.1
>
>
> In SPARK-24251, we found that the changes to use HadoopReadOptions accidentally switched the [properties that enable stats and dictionary filters|https://github.com/apache/parquet-mr/blob/8bbc6cb95fd9b4b9e86c924ca1e40fd555ecac1d/parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java#L83]. Both are enabled by default so it is unlikely that anyone will need to turn them off and there is an easy work-around, but we should fix the properties for 1.10.1. This doesn't affect the 1.8.x or 1.9.x releases (Spark 2.3.x is on 1.8.x).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)