[GitHub] [arrow-rs] viirya commented on a change in pull request #1488: Add `length` kernel support for List Array

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #1488:
URL: https://github.com/apache/arrow-rs/pull/1488#discussion_r835706638



##########
File path: arrow/src/compute/kernels/length.rs
##########
@@ -110,20 +123,24 @@ where
     unary_offsets!(array, T::DATA_TYPE, |x| x * bits_in_bytes)
 }
 
-/// Returns an array of Int32/Int64 denoting the number of bytes in each value in the array.
+/// Returns an array of Int32/Int64 denoting the length of each value in the array.
+/// For list array, length is the number of elements in each list.
+/// For string array and binary array, length is the number of bytes of each value.
 ///
-/// * this only accepts StringArray/Utf8, LargeString/LargeUtf8, BinaryArray and LargeBinaryArray
+/// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray and BinaryArray/LargeBinaryArray
 /// * length of null is null.
 /// * length is in number of bytes

Review comment:
       ```suggestion
   /// * length of null is null.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org