You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/05/18 17:26:54 UTC
[GitHub] [arrow] felipecrv opened a new pull request, #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
felipecrv opened a new pull request, #35673:
URL: https://github.com/apache/arrow/pull/35673
### Rationale for this change
Newer versions of protobuf use absl::Status instead of google::protobuf::util::Status. The `status` instances in this file are type-annotated by `auto` and we can count on the header that declares the status-returning function we are calling to have included the header that defines `Status` for us.
### What changes are included in this PR?
Removing an include of a protobuf header that don't exist in later versions of the library.
### Are these changes tested?
I haven't tried building with protobuf 23, but I can be sure this specifically fixes the problem reported in #35538.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1556124800
Benchmark runs are scheduled for baseline = 3fd8b88be37a05cfa3caaa02dcb72717b9d526c9 and contender = b80c6551570b8324298a12dc36be1b5eba76e277. b80c6551570b8324298a12dc36be1b5eba76e277 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f65e65db481348a286d038a5c935023a...56268e88f0c6451e850f8a9609e75623/)
[Finished :arrow_down:0.18% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/710c4ff2a93c4c50a2104fe3486cef13...9d99589a341b41a1b42bff082ae52668/)
[Finished :arrow_down:0.98% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/245435f3088540959a2e8038b4483025...df789bda31ca4565a205241d35a4fc0e/)
[Finished :arrow_down:0.75% :arrow_up:0.12%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ee494178678949c88dd597010cb3ce48...ade6215af3be4f73a108bbe2291ff6f1/)
Buildkite builds:
[Finished] [`b80c6551` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2899)
[Finished] [`b80c6551` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2935)
[Finished] [`b80c6551` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2900)
[Finished] [`b80c6551` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2925)
[Finished] [`3fd8b88b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2898)
[Finished] [`3fd8b88b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2934)
[Finished] [`3fd8b88b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2899)
[Finished] [`3fd8b88b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2924)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1553520440
Revision: 3d7aad902f117b0e3a2d2c02640469e7b0a5a5ea
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e7fbd041c5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e7fbd041c5)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017419520/jobs/8995509419)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/5017419980/jobs/8995510253)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017419715/jobs/8995509800)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/13590559347)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017418676/jobs/8995507871)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5017420238/jobs/8995510801)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/5017420957/jobs/8995512436)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5017419186/jobs/8995508740)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/5017420768/jobs/8995511990)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017417554/jobs/8995505408)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017417963/jobs/8995506359)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/5017417746/jobs/8995505704)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/5017418955/jobs/8995508413)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/5017421156/jobs/8995512809)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/5017417396/jobs/8995505147)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5017418169/jobs/8995506891)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1553380699
@westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1553380917
* Closes: #35538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1556125381
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/245435f3088540959a2e8038b4483025...df789bda31ca4565a205241d35a4fc0e/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #35673:
URL: https://github.com/apache/arrow/pull/35673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1554974976
> The commit that introduced this include did so via IWYU. My guess is IWYU maybe got confused between arrow::Status and protobuf Status.
It's technically correct because the code that is doing `auto status = google::protobuf::JsonSomething...` and then calling `status.ok()` needs to know that `Status` type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1553517612
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35673: GH-35538: [C++] Remove unnecessary status.h include from protobuf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35673:
URL: https://github.com/apache/arrow/pull/35673#issuecomment-1553380958
:warning: GitHub issue #35538 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org