You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/01/15 08:45:42 UTC
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #192: Better handle exceptions for JSON-RPC
codecov[bot] edited a comment on pull request #192:
URL: https://github.com/apache/incubator-tuweni/pull/192#issuecomment-760754073
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=h1) Report
> Merging [#192](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=desc) (d8c9f2b) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `4.71%`.
> The diff coverage is `37.93%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #192 +/- ##
============================================
- Coverage 65.51% 60.80% -4.72%
+ Complexity 4169 3899 -270
============================================
Files 372 350 -22
Lines 19951 19731 -220
Branches 2594 2605 +11
============================================
- Hits 13071 11997 -1074
- Misses 5421 6385 +964
+ Partials 1459 1349 -110
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.80% <37.93%> (+<0.01%)` | `0.00 <1.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <37.93%> (+18.58%)` | `4.00 <1.00> (+1.00)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [81 more](https://codecov.io/gh/apache/incubator-tuweni/pull/192/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=footer). Last update [72681ad...d8c9f2b](https://codecov.io/gh/apache/incubator-tuweni/pull/192?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org