You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by hsyuan <gi...@git.apache.org> on 2016/11/01 07:40:38 UTC

[GitHub] incubator-hawq pull request #991: HAWQ-1131. Fix error message difference be...

GitHub user hsyuan opened a pull request:

    https://github.com/apache/incubator-hawq/pull/991

    HAWQ-1131. Fix error message difference between Orca and Planner

    - In ORCA, due to the way exception handled previously we do warning first
    and then later print error referring that message. In this commit, we
    enhanced the exception handling so we just print a single error message.
    - Removed 'PQO unable to generate a plan' or 'Aborting PQO plan
    generation' message and make the error message as close as the planner.
    - Updated error message with filename and line number from where the exception
    is raised.
    - Updated regression test expected output files
    
    Patches are ported the following commits from GPDB:
    https://github.com/greenplum-db/gpdb/commit/4eb5db7a6bc8ac3faeca761193dc37e2c70e1ea3
    https://github.com/greenplum-db/gpdb/commit/d41ebde141104dd3db6fa29ac46b4096ee7d4825
    
    Author: Karthikeyan Jambu Rajaraman <ka...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsyuan/incubator-hawq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #991
    
----
commit 339c6102750f21c3d7762505b5da134b51244207
Author: Haisheng Yuan <hy...@pivotal.io>
Date:   2016-11-01T07:27:24Z

    HAWQ-1131. Fix error message difference between Orca and Planner
    
    - In ORCA, due to the way exception handled previously we do warning first
    and then later print error referring that message. In this commit, we
    enhanced the exception handling so we just print a single error message.
    - Removed 'PQO unable to generate a plan' or 'Aborting PQO plan
    generation' message and make the error message as close as the planner.
    - Updated error message with filename and line number from where the exception
    is raised.
    - Updated regression test expected output files
    
    Patches are ported the following commits from GPDB:
    https://github.com/greenplum-db/gpdb/commit/4eb5db7a6bc8ac3faeca761193dc37e2c70e1ea3
    https://github.com/greenplum-db/gpdb/commit/d41ebde141104dd3db6fa29ac46b4096ee7d4825
    
    Author: Karthikeyan Jambu Rajaraman <ka...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #991: HAWQ-1131. Fix error message difference between O...

Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:

    https://github.com/apache/incubator-hawq/pull/991
  
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #991: HAWQ-1131. Fix error message difference between O...

Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:

    https://github.com/apache/incubator-hawq/pull/991
  
    Pushed to master: 
    https://github.com/apache/incubator-hawq/commit/56b44f8595b4ba1ac9c49b775d5110e9be1275b2
    https://github.com/apache/incubator-hawq/commit/31ea7d08ede7d5bc3108454731ba11bdcf1092d1
    https://github.com/apache/incubator-hawq/commit/fed12f1a57ac64a8c7cab867f31b2930dddc2744


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #991: HAWQ-1131. Fix error message difference between O...

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/991
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #991: HAWQ-1131. Fix error message difference be...

Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/991


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---