[GitHub] [inlong] healchow commented on a diff in pull request #7233: [INLONG-7232][Manager] Supports automatic management of audit ids

[GitBox <gi...@apache.org>]

healchow commented on code in PR #7233:
URL: https://github.com/apache/inlong/pull/7233#discussion_r1070317099


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/AuditIdService.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.service.core;
+
+/**
+ * The service interface for audit id.
+ */
+public interface AuditIdService {

Review Comment:
   It is recommended to add the interface related to `AuditId` into the `AuditService`, because the Audit ID is also a part of Audit, and should be put into the same set of interfaces from the perspective of object-oriented and high cohesion.



##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/AuditIdController.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.web.controller;
+
+import io.swagger.annotations.Api;
+import io.swagger.annotations.ApiOperation;
+import org.apache.inlong.manager.pojo.common.Response;
+import org.apache.inlong.manager.service.core.AuditIdService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+/**
+ * Audit id controller.
+ */
+@RestController
+@RequestMapping("/api")
+@Api(tags = "AuditId-API")
+public class AuditIdController {

Review Comment:
   Just move those logic into the `AuditController`, please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org