You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/08/30 06:12:26 UTC

[PR] Support to show launch engine log for thrift http mode [kyuubi]

turboFei opened a new pull request, #6648:
URL: https://github.com/apache/kyuubi/pull/6648

   # :mag: Description
   ## Issue References ๐Ÿ”—
   <!-- Append the issue number after #. If there is no issue for you to link create one or -->
   <!-- If there are no issues to link, please provide details here. -->
   
   This pull request fixes #
   
   ## Describe Your Solution ๐Ÿ”ง
   
   Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
   
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   
   ## Test Plan ๐Ÿงช
   
   #### Behavior Without This Pull Request :coffin:
   
   
   #### Behavior With This Pull Request :tada:
   
   
   #### Related Unit Tests
   
   
   ---
   
   # Checklist ๐Ÿ“
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   
   - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1739043714


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#issuecomment-2322736191

   thanks, merged to 1.10.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738052860


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   ah, let's leave it then



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #6648: Support to show launch engine log for thrift http mode
URL: https://github.com/apache/kyuubi/pull/6648


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738012483


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   ```
   TFrontendService -> TBinaryFrontendService -> KyuubiTBinaryFrontendService
                                                                                 -> SparkTBinaryFrontendService
   
   TFrontendService ->  KyuubiTHttpFrontendService
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738013589


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   seems impossible 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#issuecomment-2357642661

   As this also cover https://github.com/apache/kyuubi/issues/6338 for thrift HTTP mode, backported to 1.9.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#issuecomment-2320318199

   ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6648?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `25 lines` in your changes missing coverage. Please review.
   > Project coverage is 0.00%. Comparing base [(`c9b4512`)](https://app.codecov.io/gh/apache/kyuubi/commit/c9b4512668ab54664aec829746ce8eaef320133e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0bd08d2`)](https://app.codecov.io/gh/apache/kyuubi/commit/0bd08d208051ab69268a377e8f0e55b7290b5a37?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/kyuubi/pull/6648?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/kyuubi/server/KyuubiTHttpFrontendService.scala](https://app.codecov.io/gh/apache/kyuubi/pull/6648?src=pr&el=tree&filepath=kyuubi-server%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fkyuubi%2Fserver%2FKyuubiTHttpFrontendService.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpVEh0dHBGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | 0.00% | [25 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/6648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@          Coverage Diff           @@
   ##           master   #6648   +/-   ##
   ======================================
     Coverage    0.00%   0.00%           
   ======================================
     Files         682     682           
     Lines       42167   42192   +25     
     Branches     5755    5755           
   ======================================
   - Misses      42167   42192   +25     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/6648?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738012483


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   ```
   TFrontendService -> TBinaryFrontendService ->  KyuubiTBinaryFrontendService
    TFrontendService -> TBinaryFrontendService -> SparkTBinaryFrontendService
   
   TFrontendService ->  KyuubiTHttpFrontendService
   ```



##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   ```
   TFrontendService -> TBinaryFrontendService ->  KyuubiTBinaryFrontendService
   TFrontendService -> TBinaryFrontendService -> SparkTBinaryFrontendService
   
   TFrontendService ->  KyuubiTHttpFrontendService
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738012483


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   TFrontendService -> TBinaryFrontendService -> KyuubiTBinaryFrontendService
                                                                                 -> SparkTBinaryFrontendService
   
   TFrontendService ->  KyuubiTHttpFrontendService



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738007253


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   can we have an abstract class layer to share the code then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

Re: [PR] Support to show launch engine log for thrift http mode [kyuubi]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738216293


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
     super.initialize(conf)
   }
 
+  // same as KyuubiTBinaryFrontendService, to return launch engine op handle

Review Comment:
   nit: use `/** */` for comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org