You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "jpeach (via GitHub)" <gi...@apache.org> on 2023/06/02 03:22:13 UTC
[GitHub] [trafficserver] jpeach opened a new issue, #9768: Circular dependency between iocore and tscore
jpeach opened a new issue, #9768:
URL: https://github.com/apache/trafficserver/issues/9768
If you try to run tests without doing a full build first, the build fails because of ordering issues:
```
```
However, it's not possible to re-order the build so that this works, because iocore and tscore depend on each other.
In tscore, the `MTHashTable` class uses `ProxyMutex` from iocore for locking. `ProxyMutex` pulls in `EThread` and all sorts of other iocore symbols. iocore depends on tscore all over the place, which seems reasonable and intended.
AFAICT, `MTHashTable` is only used in one place (QUIC support in iocore, see https://github.com/apache/trafficserver/issues/2478).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on issue #9768: Circular dependency between iocore and tscore
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on issue #9768:
URL: https://github.com/apache/trafficserver/issues/9768#issuecomment-1574525898
Since internal QUIC is a red herring (see #9670), we can just remove MTHashTable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach closed issue #9768: Circular dependency between iocore and tscore
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach closed issue #9768: Circular dependency between iocore and tscore
URL: https://github.com/apache/trafficserver/issues/9768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on issue #9768: Circular dependency between iocore and tscore
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on issue #9768:
URL: https://github.com/apache/trafficserver/issues/9768#issuecomment-1573089967
Looks like a reasonable solution could be to move `MTHashTable` into iocore as a private implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on issue #9768: Circular dependency between iocore and tscore
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on issue #9768:
URL: https://github.com/apache/trafficserver/issues/9768#issuecomment-1574526823
> Since internal QUIC is a red herring (see #9670), we can just remove MTHashTable again.
Ugh, except that some of the QUIC code is used? 🙄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org