You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/07/29 16:54:05 UTC
[PR] fix(arrow/csv): release record builders when Reader is released [arrow-go]
fallintoplace opened a new pull request, #1059:
URL: https://github.com/apache/arrow-go/pull/1059
CSV readers kept their RecordBuilder alive after the final Reader release. Header handling with an explicit schema also replaced the initial builder without releasing it.\n\nRelease the old builder before replacing it and release the active builder when the reader reference count reaches zero. The regression test covers both header modes with a checked allocator.\n\nValidated with ok github.com/apache/arrow-go/v18/arrow/csv 1.855s [no tests to run].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/csv): release Reader record builders [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1059:
URL: https://github.com/apache/arrow-go/pull/1059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/csv): release Reader record builders [arrow-go]
Posted by "serramatutu (via GitHub)" <gi...@apache.org>.
serramatutu commented on code in PR #1059:
URL: https://github.com/apache/arrow-go/pull/1059#discussion_r3683114227
##########
arrow/csv/reader_test.go:
##########
@@ -496,6 +496,22 @@ rec[2]["date64"]: [(null)]
}
}
+func TestReaderReleaseFreesRecordBuilder(t *testing.T) {
Review Comment:
I reverted your changes and ran the test on top of main. It passes without reproducing any bug.
<img width="1075" height="1684" alt="Image" src="https://github.com/user-attachments/assets/12100385-2cd6-4f0a-810f-b35fc4b54887" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org