You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/04/29 19:34:51 UTC
[PR] Minor: Add some more tests to map.slt [datafusion]
alamb opened a new pull request, #10301:
URL: https://github.com/apache/datafusion/pull/10301
## Which issue does this PR close?
Follow on to https://github.com/apache/datafusion/pull/10148
## Rationale for this change
While reviewing https://github.com/apache/datafusion/pull/10148 it was not clear to me from the test file output the correct answer was, so I had to go look at the file directly
It would be nice to have the test a little more self documenting
## What changes are included in this PR?
1. Add some additional coverage to `map.slt`
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
3. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: Add some more tests to map.slt [datafusion]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #10301:
URL: https://github.com/apache/datafusion/pull/10301#discussion_r1584332436
##########
datafusion/sqllogictest/test_files/map.slt:
##########
@@ -41,14 +68,18 @@ GET 27
PUT 25
DELETE 24
-query T
-SELECT strings['not_found'] FROM data LIMIT 1;
Review Comment:
can you keep the original test case here since it is non-aggregating? (in contrast to your new query)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: Add some more tests to map.slt [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10301:
URL: https://github.com/apache/datafusion/pull/10301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: Add some more tests to map.slt [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10301:
URL: https://github.com/apache/datafusion/pull/10301#issuecomment-2085431818
Thank you for the review @crepererum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: Add some more tests to map.slt [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #10301:
URL: https://github.com/apache/datafusion/pull/10301#discussion_r1584559905
##########
datafusion/sqllogictest/test_files/map.slt:
##########
@@ -41,14 +68,18 @@ GET 27
PUT 25
DELETE 24
-query T
-SELECT strings['not_found'] FROM data LIMIT 1;
Review Comment:
Great catch. I did not mean to remove the original test. Restored in b3820aafb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org