You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/04/29 01:55:12 UTC

Review Request 33648: Node auto-recovery - phase-II

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33648/
-----------------------------------------------------------

Review request for Ambari, Ivan Mitic and Sid Wagle.


Bugs: AMBARI-10029
    https://issues.apache.org/jira/browse/AMBARI-10029


Repository: ambari


Description
-------

Node auto-recovery.
Added support for:
* Pausing when commands are in pipeline
* Auto INSTALL/RESTART
* Removing stored commands when stale (jobs done or 10 minutes)


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py c7286bc 
  ambari-agent/src/main/python/ambari_agent/Controller.py 959c213 
  ambari-agent/src/main/python/ambari_agent/LiveStatus.py ec01ee7 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 3deec2b 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6aab74e 
  ambari-agent/src/test/python/ambari_agent/TestController.py f379fbf 
  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 24fad3c 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py 4cc2c0b 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 76f6a8b 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 2479f37 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 1b180eb 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java 56b4f18 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ad55c05 
  ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 0e08ed8 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java c4f5b86 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java c47b601 

Diff: https://reviews.apache.org/r/33648/diff/


Testing
-------

All agent unit tests pass. Specific unit tests for ambari-server pass. Running the whole suite now.


Thanks,

Sumit Mohanty


Re: Review Request 33648: Node auto-recovery - phase-II

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33648/#review81910
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 28, 2015, 11:55 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33648/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 11:55 p.m.)
> 
> 
> Review request for Ambari, Ivan Mitic and Sid Wagle.
> 
> 
> Bugs: AMBARI-10029
>     https://issues.apache.org/jira/browse/AMBARI-10029
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Node auto-recovery.
> Added support for:
> * Pausing when commands are in pipeline
> * Auto INSTALL/RESTART
> * Removing stored commands when stale (jobs done or 10 minutes)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py c7286bc 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 959c213 
>   ambari-agent/src/main/python/ambari_agent/LiveStatus.py ec01ee7 
>   ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 3deec2b 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6aab74e 
>   ambari-agent/src/test/python/ambari_agent/TestController.py f379fbf 
>   ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 24fad3c 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py 4cc2c0b 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 76f6a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 2479f37 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 1b180eb 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java 56b4f18 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ad55c05 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 0e08ed8 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java c4f5b86 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java c47b601 
> 
> Diff: https://reviews.apache.org/r/33648/diff/
> 
> 
> Testing
> -------
> 
> All agent unit tests pass. Specific unit tests for ambari-server pass. Running the whole suite now.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>