You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 18:53:04 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1544: [WIP] fix periodicalRebalanceExecutor
xyuanlu opened a new pull request #1544:
URL: https://github.com/apache/helix/pull/1544
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1543
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
We found there are cases after controller leadership switch, periodic rebalancer won't work as expected.
This is caused by the definition here:
```
private static final ScheduledExecutorService _periodicalRebalanceExecutor =
Executors.newSingleThreadScheduledExecutor();
```
### Tests
- [X] The following tests are written for this issue:
Will add in next change.
- [ ] The following is the result of the "mvn test" command on the appropriate module:
pending...
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1544: Fix periodicalRebalanceExecutor
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1544:
URL: https://github.com/apache/helix/pull/1544#issuecomment-729951401
This PR is ready to be merged.
Final commit message:
Fix periodicalRebalanceExecutor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1544: Fix periodicalRebalanceExecutor
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1544:
URL: https://github.com/apache/helix/pull/1544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org