You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "saurabhkushwaha438 (via GitHub)" <gi...@apache.org> on 2026/05/27 12:50:20 UTC
[PR] improved errorlog message by adding null check [cloudstack]
saurabhkushwaha438 opened a new pull request, #13263:
URL: https://github.com/apache/cloudstack/pull/13263
Implemented defensive null checks to prevent secondary NullPointerExceptions from masking the original VM import failure reason during VMware-to-KVM migration. for issue #13007
Changes made:
1. `UnmanagedVMsManagerImpl.java`
* Added a null guard before invoking `updateImportVMTaskErrorState(...)` inside the `CloudRuntimeException` catch block.
2. `ImportVmTasksManagerImpl.java`
* Added an early return in `updateImportVMTaskErrorState(...)` when the provided task object is null.
These changes ensure that the original import/conversion failure (for example missing `virt-v2v` or `nbdkit-vddk` on the target KVM host) is preserved and propagated correctly to the UI instead of being hidden by a secondary NPE during task error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "RosiKyu (via GitHub) via commits" <co...@cloudstack.apache.org>.
RosiKyu merged PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5632617467
<b>[SF] Trillian Build Failed (tid-16974)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6292472648
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5632067332
@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "nvazquez (via GitHub) via commits" <co...@cloudstack.apache.org>.
nvazquez commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6799746676
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#discussion_r3310970947
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -161,6 +161,9 @@ public void updateImportVMTaskStep(ImportVmTask importVMTask, DataCenter zone, A
@Override
public void updateImportVMTaskErrorState(ImportVmTask importVMTask, ImportVmTask.TaskState state, String errorMsg) {
+ if (importVMTask == null) {
Review Comment:
`updateImportVMTaskErrorState` silently returns when `importVMTask` is null. That can make it hard to diagnose why the import task row wasn’t updated (e.g., task creation failed earlier). Consider logging at least a WARN/DEBUG (including `state` and `errorMsg`) before returning so the original failure remains observable in server logs.
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1777,7 +1777,9 @@ protected UserVm importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
return userVm;
} catch (CloudRuntimeException e) {
logger.error(String.format("Error importing VM: %s", e.getMessage()), e);
- importVmTasksManager.updateImportVMTaskErrorState(importVMTask, ImportVmTask.TaskState.Failed, e.getMessage());
+ if (importVMTask != null) {
+ importVmTasksManager.updateImportVMTaskErrorState(importVMTask, ImportVmTask.TaskState.Failed, e.getMessage());
+ }
Review Comment:
`updateImportVMTaskErrorState(...)` now performs its own null guard, so this additional null check in the caller is redundant and duplicates the contract in two places. Consider removing the caller-side guard and relying on the manager method’s null handling to keep the behavior centralized and avoid future divergence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5631387543
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6822380644
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "saurabhkushwaha438 (via GitHub)" <gi...@apache.org>.
saurabhkushwaha438 commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-4720048734
@nvazquez , @DaanHoogland could you approve workflow and review pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "saurabhkushwaha438 (via GitHub)" <gi...@apache.org>.
saurabhkushwaha438 commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6369338636
@DaanHoogland i have resolved the remaining conversation . also do i need to add unit tests for ImportVmTasksManagerImpl so that will fix codecov/patch and Sonar JaCoCo Coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6382866031
<b>[SF] Trillian test result (tid-17235)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13263-t17235-kvm-ol8.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#discussion_r3316901966
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -99,14 +100,16 @@ private ImportVmTask.TaskState getStateFromFilter(String tasksFilter) {
try {
return ImportVmTask.TaskState.getValue(tasksFilter);
} catch (IllegalArgumentException e) {
- throw new ServerApiException(ApiErrorCode.PARAM_ERROR, String.format("Invalid value for task state: %s", tasksFilter));
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+ String.format("Invalid value for task state: %s", tasksFilter));
}
}
@Override
- public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName, String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
+ public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName,
+ String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
logger.debug("Creating import VM task entry for VM: {} for account {} on zone {} " +
- "from the vCenter: {} / datacenter: {} / source VM: {}",
+ "from the vCenter: {} / datacenter: {} / source VM: {}",
sourceVMName, owner.getAccountName(), zone.getName(), displayName, vcenter, datacenterName);
Review Comment:
```suggestion
sourceVMName, owner.getAccountName(), zone.getName(), vcenter, datacenterName, displayName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6290658308
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "RosiKyu (via GitHub) via commits" <co...@cloudstack.apache.org>.
RosiKyu commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6822369802
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#discussion_r3316082636
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -99,14 +100,16 @@ private ImportVmTask.TaskState getStateFromFilter(String tasksFilter) {
try {
return ImportVmTask.TaskState.getValue(tasksFilter);
} catch (IllegalArgumentException e) {
- throw new ServerApiException(ApiErrorCode.PARAM_ERROR, String.format("Invalid value for task state: %s", tasksFilter));
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+ String.format("Invalid value for task state: %s", tasksFilter));
}
}
@Override
- public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName, String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
+ public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName,
+ String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
logger.debug("Creating import VM task entry for VM: {} for account {} on zone {} " +
- "from the vCenter: {} / datacenter: {} / source VM: {}",
+ "from the vCenter: {} / datacenter: {} / source VM: {}",
sourceVMName, owner.getAccountName(), zone.getName(), displayName, vcenter, datacenterName);
Review Comment:
The placeholder arguments in this debug log are mis-ordered: the message expects (vCenter, datacenter, source VM) but the code passes (displayName, vcenter, datacenterName). This will log incorrect values and make troubleshooting harder; please reorder the arguments (and/or adjust the message) so each placeholder matches the intended field.
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -139,11 +147,12 @@ private String getStepDescription(ImportVMTaskVO importVMTaskVO, Host convertHos
@Override
public void updateImportVMTaskStep(ImportVmTask importVMTask, DataCenter zone, Account owner, Host convertHost,
- Host importHost, Long vmId, ImportVmTask.Step step) {
+ Host importHost, Long vmId, ImportVmTask.Step step) {
ImportVMTaskVO importVMTaskVO = (ImportVMTaskVO) importVMTask;
logger.debug("Updating import VM task entry for VM: {} for account {} on zone {} " +
- "from the vCenter: {} / datacenter: {} / source VM: {} to step: {}",
- importVMTaskVO.getSourceVMName(), owner.getAccountName(), zone.getName(), importVMTaskVO.getDisplayName(),
+ "from the vCenter: {} / datacenter: {} / source VM: {} to step: {}",
+ importVMTaskVO.getSourceVMName(), owner.getAccountName(), zone.getName(),
+ importVMTaskVO.getDisplayName(),
importVMTaskVO.getVcenter(), importVMTaskVO.getDatacenter(), step);
Review Comment:
This debug log also appears to pass arguments in the wrong order: the message includes placeholders for vCenter, datacenter, and source VM, but `importVMTaskVO.getDisplayName()` is provided where the vCenter is expected, shifting the remaining values. Please realign the arguments with the placeholders to avoid misleading log output.
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1755,48 +2014,62 @@ protected UserVm importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
serviceOffering, dataDiskOfferingMap, temporaryConvertLocation,
ovfTemplateOnConvertLocation, forceConvertToPool, extraParams);
} else {
- // Uses KVM Host for direct conversion using VDDK, or for OVF export to temporary conversion location through ovftool
- importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost, null, ConvertingInstance);
+ // Uses KVM Host for direct conversion using VDDK, or for OVF export to
+ // temporary conversion location through ovftool
+ importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost, null,
+ ConvertingInstance);
convertedInstance = convertVmwareInstanceToKVMUsingVDDKOrAfterExportingOVFToConvertLocation(
sourceVMName, sourceVMwareInstance, convertHost, importHost,
convertStoragePools, serviceOffering, dataDiskOfferingMap,
- temporaryConvertLocation, vcenter, username, password, datacenterName, forceConvertToPool, extraParams, useVddk, details);
+ temporaryConvertLocation, vcenter, username, password, datacenterName, forceConvertToPool,
+ extraParams, useVddk, details);
}
sanitizeConvertedInstance(convertedInstance, sourceVMwareInstance);
- importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost, null, Importing);
+ importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost, null,
+ Importing);
UserVm userVm = importVirtualMachineInternal(convertedInstance, null, zone, destinationCluster, null,
template, displayName, hostName, caller, owner, userId,
serviceOffering, dataDiskOfferingMap,
nicNetworkMap, nicIpAddressMap, guestOsId,
details, false, forced, false);
long timeElapsedInSecs = (System.currentTimeMillis() - importStartTime) / 1000;
- logger.debug(String.format("VMware VM %s imported successfully to CloudStack instance %s (%s), Time taken: %d secs, OVF files imported from %s, Source VMware VM details - OS: %s, PowerState: %s, Disks: %s, NICs: %s",
- sourceVMName, displayName, displayName, timeElapsedInSecs, (ovfTemplateOnConvertLocation != null)? "MS" : "KVM Host", sourceVMwareInstance.getOperatingSystem(), sourceVMwareInstance.getPowerState(), sourceVMwareInstance.getDisks(), sourceVMwareInstance.getNics()));
- importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost, userVm.getId(), Completed);
+ logger.debug(String.format(
+ "VMware VM %s imported successfully to CloudStack instance %s (%s), Time taken: %d secs, OVF files imported from %s, Source VMware VM details - OS: %s, PowerState: %s, Disks: %s, NICs: %s",
+ sourceVMName, displayName, displayName, timeElapsedInSecs,
+ (ovfTemplateOnConvertLocation != null) ? "MS" : "KVM Host",
+ sourceVMwareInstance.getOperatingSystem(), sourceVMwareInstance.getPowerState(),
+ sourceVMwareInstance.getDisks(), sourceVMwareInstance.getNics()));
+ importVmTasksManager.updateImportVMTaskStep(importVMTask, zone, owner, convertHost, importHost,
+ userVm.getId(), Completed);
return userVm;
} catch (CloudRuntimeException e) {
logger.error(String.format("Error importing VM: %s", e.getMessage()), e);
- importVmTasksManager.updateImportVMTaskErrorState(importVMTask, ImportVmTask.TaskState.Failed, e.getMessage());
- ActionEventUtils.onCompletedActionEvent(userId, owner.getId(), EventVO.LEVEL_ERROR, EventTypes.EVENT_VM_IMPORT,
- cmd.getEventDescription(), null, null, 0);
+ importVmTasksManager.updateImportVMTaskErrorState(importVMTask, ImportVmTask.TaskState.Failed,
+ e.getMessage());
+ ActionEventUtils.onCompletedActionEvent(userId, owner.getId(), EventVO.LEVEL_ERROR,
+ EventTypes.EVENT_VM_IMPORT, cmd.getEventDescription(), null, null, 0);
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, e.getMessage());
Review Comment:
The PR description mentions adding a null guard before calling `updateImportVMTaskErrorState(...)` here, but the call site still invokes it unconditionally. Since the callee now early-returns on null, this is functionally safe, but it would be clearer to either add the caller-side guard (avoiding the extra warn log) or update the PR description to reflect the actual change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "saurabhkushwaha438 (via GitHub)" <gi...@apache.org>.
saurabhkushwaha438 commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5218886278
Hi @nvazquez , I've resolved the merge conflicts and updated this PR with the latest main. The CI has been rerun. I'd appreciate a review whenever you have time. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5630896418
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "saurabhkushwaha438 (via GitHub)" <gi...@apache.org>.
saurabhkushwaha438 commented on code in PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#discussion_r3316396987
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -99,14 +100,16 @@ private ImportVmTask.TaskState getStateFromFilter(String tasksFilter) {
try {
return ImportVmTask.TaskState.getValue(tasksFilter);
} catch (IllegalArgumentException e) {
- throw new ServerApiException(ApiErrorCode.PARAM_ERROR, String.format("Invalid value for task state: %s", tasksFilter));
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+ String.format("Invalid value for task state: %s", tasksFilter));
}
}
@Override
- public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName, String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
+ public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName,
+ String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
logger.debug("Creating import VM task entry for VM: {} for account {} on zone {} " +
- "from the vCenter: {} / datacenter: {} / source VM: {}",
+ "from the vCenter: {} / datacenter: {} / source VM: {}",
sourceVMName, owner.getAccountName(), zone.getName(), displayName, vcenter, datacenterName);
Review Comment:
this is not actual change that i made , it is just a formatting to pass CI build because maven build enforces strict checkstyle rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5632057918
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6290693148
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6290611581
@saurabhkushwaha438 thanks for taking care of the conflicts. Could you answer the co-pilot's remarks, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6370459439
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-4554808656
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.51%. Comparing base ([`3f6866d`](https://app.codecov.io/gh/apache/cloudstack/commit/3f6866d70a6e4eb8a12dd257d33bde5aae79aacf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afeae99`](https://app.codecov.io/gh/apache/cloudstack/commit/afeae994f8b9068158c97a3e169fb303e09a36b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (3f6866d) and HEAD (afeae99). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (3f6866d) | HEAD (afeae99) |
>|------|------|------|
>|uitests|3|1|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #13263 +/- ##
=============================================
- Coverage 18.11% 3.51% -14.60%
=============================================
Files 6037 464 -5573
Lines 542783 40157 -502626
Branches 66454 7559 -58895
=============================================
- Hits 98301 1413 -96888
+ Misses 433438 38554 -394884
+ Partials 11044 190 -10854
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.51% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13263?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#discussion_r3316907910
##########
server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java:
##########
@@ -99,14 +100,16 @@ private ImportVmTask.TaskState getStateFromFilter(String tasksFilter) {
try {
return ImportVmTask.TaskState.getValue(tasksFilter);
} catch (IllegalArgumentException e) {
- throw new ServerApiException(ApiErrorCode.PARAM_ERROR, String.format("Invalid value for task state: %s", tasksFilter));
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+ String.format("Invalid value for task state: %s", tasksFilter));
}
}
@Override
- public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName, String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
+ public ImportVmTask createImportVMTaskRecord(DataCenter zone, Account owner, long userId, String displayName,
+ String vcenter, String datacenterName, String sourceVMName, Host convertHost, Host importHost) {
logger.debug("Creating import VM task entry for VM: {} for account {} on zone {} " +
- "from the vCenter: {} / datacenter: {} / source VM: {}",
+ "from the vCenter: {} / datacenter: {} / source VM: {}",
sourceVMName, owner.getAccountName(), zone.getName(), displayName, vcenter, datacenterName);
Review Comment:
don’t worry about it @saurabhkushwaha438 . you can apply the suggestion (mine is better than co-pilot’s ;) ) or just resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5812961290
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-5630887077
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6176282473
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6370449450
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improved errorlog message by adding null check [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #13263:
URL: https://github.com/apache/cloudstack/pull/13263#issuecomment-6824172694
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org