[GitHub] [cassandra] adelapena commented on a diff in pull request #2436: CASSANDRA-18613 trunk: Add support for vectors on UDFs

["adelapena (via GitHub)" <gi...@apache.org>]

adelapena commented on code in PR #2436:
URL: https://github.com/apache/cassandra/pull/2436#discussion_r1255969143


##########
src/java/org/apache/cassandra/cql3/functions/types/GettableByIndexData.java:
##########
@@ -465,6 +465,21 @@ public interface GettableByIndexData
      */
     public <K, V> Map<K, V> getMap(int i, TypeToken<K> keysType, TypeToken<V> valuesType);
 
+    /**
+     * Returns the {@code i}th value as a vector.
+     *
+     * <p>This method uses the {@link CodecRegistry} to find a codec to convert the underlying CQL
+     * type to a {@link List} (if the CQL type is a UDT, the registry will generate a codec

Review Comment:
   I've wrongly copied that comment from the getter for UDTs. Revisiting this has made me realise that the getters/setters are incorrect for usage with nested types. I have just fixed them and added a new test case covering them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org