You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/10 17:48:59 UTC
[GitHub] kl0u commented on a change in pull request #7385: [hotfix]Fix some
logging statements which can not correctly record the behaviors
kl0u commented on a change in pull request #7385: [hotfix]Fix some logging statements which can not correctly record the behaviors
URL: https://github.com/apache/flink/pull/7385#discussion_r255347572
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -759,7 +759,7 @@ public void declineCheckpoint(DeclineCheckpoint decline) {
return CompletableFuture.completedFuture(Acknowledge.get());
} catch (Exception e) {
- log.error("Failed to notify KvStateRegistry about registration {}.", registrationName);
+ log.error("Failed to notify KvStateRegistry about registration {}.", registrationName, e);
Review comment:
I think adding the exception logging is correct. It is logged at `error` level so it is the right thing to do I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services