You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/02 17:14:18 UTC

[GitHub] [druid] suneet-s opened a new pull request #9968: Add the ability to run sql tests from a config file

suneet-s opened a new pull request #9968:
URL: https://github.com/apache/druid/pull/9968


   This PR aims to make it easier for non Druid devs to add sql tests to Druid.
   
   If anyone in the community has particular query shapes they expect to see
   working in Druid, they can add the queries to the provided config.
   This will ensure the queries work as expected with each Druid release.
   
   Sample ingestion specs are provided in the test/resources folder so that tests
   are easier to build by testing against a local cluster.
   
   yaml is chosen as the data format for the tests as it allows devs to place
   comments within the configuration which helps with maintainability of the
   tests.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] stale[bot] commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-683335148


   This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] stale[bot] commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-667569686


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-637692961


   Tagged "Design Review" because it seems not easy to change once we choose the design of the testing framework (we may need to update all the test specs in the yaml file if we want to change the test spec later).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-637690074


   I like this idea 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] stale[bot] closed pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9968:
URL: https://github.com/apache/druid/pull/9968


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-637690823


   Open to feedback on if this is useful / other approaches to make CalciteQueryTests more complete. 
   
   I don't think these parameterized tests need to run on every PR, having them run nightly might be a good compromise on compute time vs test coverage - but I don't know how to have that work with Travis.
   
   I still need to try a few more query shapes to validate that it's easy to add new tests.
   This framework also doesn't make it easy to deal with different results for null handling mode enabled vs disabled.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] ccaominh commented on pull request #9968: Add the ability to run sql tests from a config file

Posted by GitBox <gi...@apache.org>.
ccaominh commented on pull request #9968:
URL: https://github.com/apache/druid/pull/9968#issuecomment-637694637


   > I don't think these parameterized tests need to run on every PR, having them run nightly might be a good compromise on compute time vs test coverage - but I don't know how to have that work with Travis.
   
   Travis is already setup to run a daily job, which will run any jobs that are in the `cron` stage. For an example, refer the the "security vulnerabilities" job: https://github.com/apache/druid/blob/master/.travis.yml#L426
   
   The configuration that restricts the cron job to only run the `cron` stage is here: https://github.com/apache/druid/blob/master/.travis.yml#L41
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org