You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Adam Tamas (Code Review)" <ge...@cloudera.org> on 2020/07/12 15:56:42 UTC

[Impala-ASF-CR] WIP IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Adam Tamas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16179


Change subject: WIP IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................

WIP IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Testxing:
 - Ran ASAN with EE_TEST_SHARDS=6

Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
---
M be/src/exprs/expr-test.cc
M be/src/runtime/date-parse-util.cc
M be/src/runtime/datetime-simple-date-format-parser.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/timestamp-parse-util.h
6 files changed, 64 insertions(+), 70 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/16179/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6571/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 12:10:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 14:52:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16179/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16179/3//COMMIT_MSG@13
PS3, Line 13: Testxing
typo


http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/exprs/expr-test.cc@3311
PS3, Line 3311: TestTimestampValue("cast('  \t\r\n      01:05:01   \t\r\n     ' as timestamp)",
              :       TimestampValue::ParseSimpleDateFormat("01:05:01"));
Does this produce a valid TS?


http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/exprs/expr-test.cc@3313
PS3, Line 3313: //  TestIsNull("cast(' \t\r\n 01:05:01.123456789   \t\r\n     ' as timestamp)",
              : //      TYPE_TIMESTAMP);
Please don't leave commented code.


http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/exprs/expr-test.cc@3327
PS3, Line 3327: TestIsNull("cast('  \t\r\n      1:5:1    \t\r\n    ' as timestamp)", TYPE_TIMESTAMP);
              :   TestIsNull(
              :       "cast('  \t\r\n      1:5:1.12345678    \t\r\n    ' as timestamp)", TYPE_TIMESTAMP);
These have nothing to do with IMPALA-6995, please move them to a different section of the test file.


http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/runtime/datetime-simple-date-format-parser.cc
File be/src/runtime/datetime-simple-date-format-parser.cc:

http://gerrit.cloudera.org:8080/#/c/16179/3/be/src/runtime/datetime-simple-date-format-parser.cc@346
PS3, Line 346: str[4]
For me the root cause is still a bit unclear. The ASAN build said that for certain inputs here we try to read from memory that was actually released. I wonder how come we get to this point when we had released 'str' and where it is actually released?



-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 09:24:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 5:

(2 comments)

The patch seems fine. Could you comment on the Jira for IMPALA-9531 that this (IMPALA-9941) is also required?

http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@12
PS4, Line 12: Updated some missed files connected to the drop of dateless
> Done
Much better, thanks!


http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3324
PS4, Line 3324: TestIsNull
> After IMPALA-9531 both the cast and the TimestampValue::ParseSimpleDateForm
Thx for the explanation! I agree it's better to be a null check.



-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 08:53:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 19:54:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 08:54:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.

Adam Tamas has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................

IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Fixed the issue with the ASAN build where too short tokens in
timestamps fails because of indexing out of bounds because of a
missing check.
Updated some missed files connected to the drop of dateless timestamps
(IMPALA-9531) regarding tests, comments.

Testing:
 - Ran CORE tests
 - Ran ASAN with EE_TEST_SHARDS=6 (with the help of IMPALA-9887)

Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
---
M be/src/exprs/expr-test.cc
M be/src/runtime/date-parse-util.cc
M be/src/runtime/datetime-simple-date-format-parser.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/timestamp-parse-util.h
6 files changed, 67 insertions(+), 72 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/16179/5
-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6128/


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 13:57:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@9
PS4, Line 9: in a
           : timestamps
typo


http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@10
PS4, Line 10: becouse
same typo


http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@10
PS4, Line 10: becouse
typo


http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@12
PS4, Line 12: Updated files connected to the drop of dateless timestamps.
I don't see the point of this sentence. Here we don't know what files have been changed by that other patch so this doesn't bring too much value.


http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3318
PS4, Line 3318: //IMPALA-9531
nit: leave a space after //


http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3324
PS4, Line 3324: TestIsNull
I don't understand. In Patch Set 3 this was a positive test, checking that this input results in a valid output. Then in PS4 you changed this to expect null instead without having any relevant code changes. Was it failing in PS3 or is it failing now in PS4?



-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 19:51:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.

Adam Tamas has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................

IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Fixed the issue with the ASAN build where only date tokens with
wrong format in a timestamps fails.
Updated files connected to the drop of dateless timestamps.

Testxing:
 - Ran CORE tests
 - Ran ASAN with EE_TEST_SHARDS=6 (with the help of IMPALA-9887)

Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
---
M be/src/exprs/expr-test.cc
M be/src/runtime/date-parse-util.cc
M be/src/runtime/datetime-simple-date-format-parser.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/timestamp-parse-util.h
6 files changed, 64 insertions(+), 70 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/16179/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Adam Tamas (Code Review)" <ge...@cloudera.org>.

Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 6:

> (2 comments)
 > 
 > The patch seems fine. Could you comment on the Jira for IMPALA-9531
 > that this (IMPALA-9941) is also required?

Done and thank you for reviewing!


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 09:10:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................

IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Fixed the issue with the ASAN build where too short tokens in
timestamps fails because of indexing out of bounds because of a
missing check.
Updated some missed files connected to the drop of dateless timestamps
(IMPALA-9531) regarding tests, comments.

Testing:
 - Ran CORE tests
 - Ran ASAN with EE_TEST_SHARDS=6 (with the help of IMPALA-9887)

Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Reviewed-on: http://gerrit.cloudera.org:8080/16179
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M be/src/runtime/date-parse-util.cc
M be/src/runtime/datetime-simple-date-format-parser.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/timestamp-parse-util.h
6 files changed, 67 insertions(+), 72 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )

Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6588/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf
Gerrit-Change-Number: 16179
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 08:13:19 +0000
Gerrit-HasComments: No