You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/01/18 02:51:51 UTC
[GitHub] [echarts] pissang commented on a change in pull request #16372: fix(dtatsample): fix rate infinity cause range error
pissang commented on a change in pull request #16372:
URL: https://github.com/apache/echarts/pull/16372#discussion_r786381469
##########
File path: src/processor/dataSample.ts
##########
@@ -94,7 +94,7 @@ export default function dataSample(seriesType: string): StageHandler {
const size = Math.abs(extent[1] - extent[0]) * (dpr || 1);
const rate = Math.round(count / size);
- if (rate > 1) {
Review comment:
Using `isFinte(rate)` may be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org