Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

[Kevin Risden <kr...@apache.org>]

Based on the comments in the two files (o.a.c.u.Compatible and
o.a.c.u.CompatibleGuava11), they were added to ensure that Calcite was
compatible with Guava 11 and JDK 1.7. As of Calcite 1.16.0, JDK 1.8 and
Guava 19 are minimum requirements.

I think that means that both Compatible and CompatibleGuava11 can be
removed since they should no longer be used.

Does this seem to be correct?

Kevin Risden

Re: Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

[Julian Hyde <jh...@apache.org>]

Kevin,

I think we should remove those classes.

We may run into compatibility issues in future — or, as in this case, want to use features that are in a version of a library or the JDK that not all of our users are happy to upgrade to — and if so, we can always resurrect the files from git history.

Julian


> On Sep 9, 2018, at 9:16 AM, Vladimir Sitnikov <si...@gmail.com> wrote:
> 
> Kevin>I think that means that both Compatible and CompatibleGuava11 can be
> removed since they should no longer be used.
> 
> Could we keep the files as a monument to Guava's version policy?
> 
> Vladimir

Re: Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

[Vladimir Sitnikov <si...@gmail.com>]

Kevin>I think that means that both Compatible and CompatibleGuava11 can be
removed since they should no longer be used.

Could we keep the files as a monument to Guava's version policy?

Vladimir